Skip to content

fix(alert-preferences): country/region selections#2376

Merged
frozenhelium merged 1 commit into
project/email-alertsfrom
fix/country-selections
May 22, 2026
Merged

fix(alert-preferences): country/region selections#2376
frozenhelium merged 1 commit into
project/email-alertsfrom
fix/country-selections

Conversation

@subinasr
Copy link
Copy Markdown
Collaborator

@subinasr subinasr commented May 20, 2026

Summary

Fix the glitchy behaviour of region and country selections

Depends On

IFRCGo/go-api#2648

Changes

  • Remove unrelated hazards
  • Fix the selection behavior of region/countries

This PR Ensures:

  • No typos or grammatical errors
  • No conflict markers left in the code
  • No unwanted comments, temporary files, or auto-generated files
  • No inclusion of secret keys or sensitive data
  • No console.log statements meant for debugging
  • All CI checks have passed

@subinasr subinasr marked this pull request as ready for review May 20, 2026 11:18
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 20, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: bee72a2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@subinasr subinasr requested a review from frozenhelium May 21, 2026 04:40
@subinasr subinasr force-pushed the fix/country-selections branch from 4b0c183 to 3a26bfc Compare May 21, 2026 04:47
frozenhelium
frozenhelium requested changes May 21, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@frozenhelium frozenhelium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also add a short description on email alerts and also about the source and maybe a bit about the what to expect in the content of alert (Montandon)

Comment thread app/src/views/AccountNotifications/EmailPreferences/SubscriptionModal/index.tsx Outdated
Comment on lines +67 to +81
// NOTE: Email alerts only supports 3 disasters at the moment
const disasterTypeOptions = [
{
id: 2,
name: 'Earthquake',
},
{
id: 4,
name: 'Cyclone',
},
{
id: 12,
name: 'Flood',
},
];
Copy link
Copy Markdown
Member

@frozenhelium frozenhelium May 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add these with translations

@frozenhelium frozenhelium force-pushed the fix/country-selections branch from b41c6d6 to 26c44fc Compare May 22, 2026 01:53
@subinasr subinasr force-pushed the fix/country-selections branch from ffca48f to 725de70 Compare May 22, 2026 05:58
@frozenhelium frozenhelium force-pushed the fix/country-selections branch from 725de70 to bee72a2 Compare May 22, 2026 05:59
@subinasr subinasr requested a review from frozenhelium May 22, 2026 05:59
@frozenhelium frozenhelium merged commit 39cd542 into project/email-alerts May 22, 2026
18 checks passed
@frozenhelium frozenhelium deleted the fix/country-selections branch May 22, 2026 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frozenhelium frozenhelium frozenhelium approved these changes

Assignees

@frozenhelium frozenhelium

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@subinasr @frozenhelium