fix: Add explicit dependency checks for optional components#29
Merged
Conversation
Add early CMake dependency validation for optional components to provide clear error messages when required packages are missing: - snapshot_library: Check for libarchive-devel - command_line_tool: Check for rapidjson-devel - cpp decoder: Check for boost-devel Each check provides actionable error message with the CMake flag to disable the component if the dependency cannot be installed. This prevents cryptic build failures later in the build process and aligns with the Gradle build system's component enable/disable flags. Signed-off-by: Martin Andres <mandres@de.ibm.com> Signed-off-by: Michael Andres <michael.andres@ibm.com>
eyebeem-mikel
force-pushed
the
fix/add-cmake-dependency-checks
branch
from
4fa6f03 to
ab2e357
Compare
Prevent CPack from automatically generating source RPMs (ibmsource RPMs) during normal package builds. Source RPMs can still be built explicitly via the 'srpm' custom target when needed. This reduces build artifacts and aligns with typical RPM packaging workflows where source RPMs are only generated on demand. Signed-off-by: Michael Andres <michael.andres@ibm.com>
Bump version for PR #29 changes: - Add explicit dependency checks for optional components - Disable automatic source RPM generation - Prevent cryptic build failures when dependencies are missing Signed-off-by: Michael Andres <michael.andres@ibm.com>
Jo5ta
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add early CMake dependency validation for optional components to provide clear error messages when required packages are missing.
Changes
Each check provides an actionable error message with the CMake flag to disable the component if the dependency cannot be installed (e.g.,
-DCLLTK_SNAPSHOT=OFF).Benefits
Testing
The changes can be tested by:
Relates to the CommonLowLevelTracingKit_build Gradle integration work.