Conversation
benel
left a comment
benel
left a comment
There was a problem hiding this comment.
Thank you very much for your contribution @LeMouj and @Come-Peyrelongue.
This seems to be very promising.
However, before being merged several changes are necessary...
Concerning the name of the ticket (and then the commits titles), please consider first my 2-months-old comment. Its conclusion is that it is probably a new sub-feature of "Create a comment from a fragment" as described in comment_fragment.feature
As such:
- tickets and implementation commit should be labeled as
FEATURE, - tickets and commits should be named appropriately,
- its scenario should be added to the file above.
The main scenario step should be something like Quand je sélectionne le fragment de vidéo de "00:03:09.000" à "00:03:15.000". This means that you have to put together all the steps you detailed before. This means also that you should not describe the user interface specificities (to be done independently from the mockup). Those two rules were defined in the course about scenarios.
If you have any question or if you need help, please ask.
| }); | ||
| }); | ||
|
|
||
| Cypress.Commands.add('stub_youtube_api', () => { |
There was a problem hiding this comment.
Can you explain why you need this function and how does it work?
3 participants
Updated the scenario to split a video and modified the expected document list.
Co-authored-by: Enzo MOUGIN enzo.mougin@utt.fr
Co-authored-by: Côme PEYRELONGUE come.peyrelongue@utt.fr
We, Enzo MOUGIN & Côme PEYRELONGUE, hereby grant to Hyperglosae maintainers the right to publish our contribution under the terms of any licenses the Free Software Foundation classifies as Free Software Licenses.