Skip to content

Commit dae7e6d

Browse files
committed
chore(app): 53.0.1318; NSIS InstFiles SetDetailsView show
Bump the app package version (package.json + lockfile). In the assisted installer InstFiles SHOW hook, call SetDetailsView show before SetDetailsPrint so the detail log pane is actually expanded at runtime; electron-builder’s common.nsh uses ShowInstDetails nevershow, and SetDetailsPrint alone does not open the details view (see NSIS SetDetailsView). Made-with: Cursor
1 parent 86aa262 commit dae7e6d

3 files changed

Lines changed: 7 additions & 6 deletions

File tree

app/package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"url": "https://github.com/HyperlinksSpace/HyperlinksSpaceBot.git"
99
},
1010
"main": "expo-router/entry",
11-
"version": "53.0.1317",
11+
"version": "53.0.1318",
1212
"type": "module",
1313
"engines": {
1414
"node": ">=18 <=22"

app/windows/installer-hooks.nsi

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@ CRCCheck off
1616

1717
; assistedInstaller.nsh runs !ifmacrodef customPageAfterChangeDir immediately *before* MUI_PAGE_INSTFILES.
1818
; common.nsh sets ShowInstDetails nevershow; customHeader runs *after* assistedInstaller, so
19-
; ShowInstDetails show there is too late — the InstFiles page is already generated hidden (only the
20-
; stub line / progress text shows). Emit ShowInstDetails show here so the details list exists.
21-
; Hook SHOW for runtime SetDetailsPrint (belt-and-suspenders).
19+
; ShowInstDetails show there is too late for page layout. Emit ShowInstDetails show here.
20+
; On the InstFiles SHOW callback also call SetDetailsView show — that is what actually expands the
21+
; detail log at runtime (SetDetailsPrint alone does not; see NSIS Reference/SetDetailsView).
2222
; Omit when BUILD_UNINSTALLER: the uninstaller pass has no installer InstFiles page; an unreferenced
2323
; Function triggers NSIS warning 6010 and electron-builder fails (warnings as errors).
2424
!ifndef BUILD_UNINSTALLER
@@ -29,6 +29,7 @@ CRCCheck off
2929

3030
Function HspInstFilesShow
3131
; Match installSection: do not gate on ${Silent} here.
32+
SetDetailsView show
3233
SetDetailsPrint both
3334
FunctionEnd
3435
!endif

0 commit comments

Comments
 (0)