fix(win): zip apply helper plan path + NSIS install log visibility

Pass -PlanPath to the detached PowerShell apply script so the update plan is always available (Windows detached spawn often does not pass custom env vars such as HSP_UPDATE_PLAN). Improve fatal error logging when Write-ApplyLog is not yet available.

Emit ShowInstDetails show in customPageAfterChangeDir before MUI_PAGE_INSTFILES. common.nsh sets nevershow and customHeader runs after assistedInstaller, so the InstFiles page was built without a details list; DetailPrint had nowhere to appear.

Made-with: Cursor

Author: anriltine

app/windows/build.cjs

@@ -1116,9 +1116,10 @@ function setupAutoUpdater() {
         settleMs = Math.min(5000, Math.max(0, defaultSettle));
       }
       const ps1Body = [
+        "param([string]$PlanPath)",
         '$ErrorActionPreference = "Stop"',
-        "$PlanPath = $env:HSP_UPDATE_PLAN",
-        'if (-not $PlanPath) { throw "HSP_UPDATE_PLAN environment variable is missing" }',
+        "if (-not $PlanPath) { $PlanPath = $env:HSP_UPDATE_PLAN }",
+        'if (-not $PlanPath) { throw "Plan path missing (pass -PlanPath to this script or set HSP_UPDATE_PLAN)" }',
         "$plan = Get-Content -LiteralPath $PlanPath -Encoding UTF8 -Raw | ConvertFrom-Json",
         "$LogFile = $plan.logPath",
         `$settleMs = ${settleMs}`,
@@ -1183,7 +1184,9 @@ function setupAutoUpdater() {
         "  try { Remove-Item -LiteralPath $PlanPath -Force } catch {}",
         '  Write-ApplyLog "apply done"',
         "} catch {",
-        '  Write-ApplyLog ("FATAL: " + $_.Exception.Message)',
+        '  $err = "FATAL: " + $_.Exception.Message',
+        "  if ($LogFile) { try { Write-ApplyLog $err } catch {} }",
+        "  elseif ($plan -and $plan.logPath) { try { Add-Content -LiteralPath $plan.logPath -Value (\"[\" + (Get-Date).ToUniversalTime().ToString('yyyy-MM-ddTHH:mm:ss.fffZ') + \"] \" + $err) -Encoding UTF8 } catch {} }",
         "  try { Remove-Item -LiteralPath $PlanPath -Force } catch {}",
         "  exit 1",
         "}",
@@ -1203,15 +1206,19 @@ function setupAutoUpdater() {
       const systemRoot = process.env.SystemRoot || process.env.SYSTEMROOT || "C:\\Windows";
       const psExe = path.join(systemRoot, "System32", "WindowsPowerShell", "v1.0", "powershell.exe");
 
-      const child = spawn(psExe, ["-NoProfile", "-ExecutionPolicy", "Bypass", "-File", ps1Path], {
-        env: { ...process.env, HSP_UPDATE_PLAN: planPath },
-        detached: true,
-        stdio: "ignore",
-        windowsHide: true,
-      });
+      const child = spawn(
+        psExe,
+        ["-NoProfile", "-ExecutionPolicy", "Bypass", "-File", ps1Path, "-PlanPath", planPath],
+        {
+          env: { ...process.env, HSP_UPDATE_PLAN: planPath },
+          detached: true,
+          stdio: "ignore",
+          windowsHide: true,
+        },
+      );
       logUpdater(
         "apply",
-        `spawn ${psExe} pid=${child.pid} detached=true env HSP_UPDATE_PLAN (robocopy staging → installDir, then relaunch exe)`,
+        `spawn ${psExe} pid=${child.pid} detached=true -PlanPath + HSP_UPDATE_PLAN (robocopy / junction, relaunch)`,
       );
       child.unref();
       if (!child.pid) {

app/windows/installer-hooks.nsi

@@ -14,18 +14,21 @@
 ; multiple electron-builder users on some Windows machines.
 CRCCheck off
 
-; assistedInstaller.nsh runs !ifmacrodef customPageAfterChangeDir immediately before MUI_PAGE_INSTFILES.
-; Hook SHOW only (not PRE) so we do not override electron-builder's instFilesPre when
-; allowToChangeInstallationDirectory is true. Runtime SetDetailsPrint fixes empty InstFiles log.
+; assistedInstaller.nsh runs !ifmacrodef customPageAfterChangeDir immediately *before* MUI_PAGE_INSTFILES.
+; common.nsh sets ShowInstDetails nevershow; customHeader runs *after* assistedInstaller, so
+; ShowInstDetails show there is too late — the InstFiles page is already generated hidden (only the
+; stub line / progress text shows). Emit ShowInstDetails show here so the details list exists.
+; Hook SHOW for runtime SetDetailsPrint (belt-and-suspenders).
 ; Omit when BUILD_UNINSTALLER: the uninstaller pass has no installer InstFiles page; an unreferenced
 ; Function triggers NSIS warning 6010 and electron-builder fails (warnings as errors).
 !ifndef BUILD_UNINSTALLER
 !macro customPageAfterChangeDir
+  ShowInstDetails show
   !define MUI_PAGE_CUSTOMFUNCTION_SHOW HspInstFilesShow
 !macroend
 
 Function HspInstFilesShow
-  ; Match installSection: do not gate on ${Silent} here. Only ensure details are enabled; steps come from the section.
+  ; Match installSection: do not gate on ${Silent} here.
   SetDetailsPrint both
 FunctionEnd
 !endif