fix(windows): silent NSIS PowerShell via nsExec and shell taskbar icon

Replace ExecWait with nsExec::Exec for hsp-app-process.ps1 so powershell.exe does not attach a flashing console. On packaged Windows, apply app.getFileIcon (large) to the main BrowserWindow so the taskbar gets a real icon when createFromPath on the exe is empty.

Made-with: Cursor

Author: staindart

app/windows/build.cjs

@@ -1816,6 +1816,32 @@ function createWindow() {
     show: false,
   });
 
+  // Windows: nativeImage.createFromPath(.exe) often returns an empty image; shell-extracted icons work for the taskbar.
+  if (process.platform === "win32" && app.isPackaged) {
+    const iconPaths = [resolveAppIconIcoPath(), process.execPath].filter(
+      (p) => p && (p === process.execPath || fs.existsSync(p)),
+    );
+    void (async () => {
+      for (const p of iconPaths) {
+        try {
+          const img = await app.getFileIcon(p, { size: "large" });
+          if (mainWindow.isDestroyed()) return;
+          if (!img.isEmpty()) {
+            mainWindow.setIcon(img);
+            return;
+          }
+        } catch (e) {
+          try {
+            log(`getFileIcon(${p}): ${e?.message || e}`);
+          } catch (_) {}
+        }
+      }
+      try {
+        log("warn: taskbar icon: getFileIcon found no usable image");
+      } catch (_) {}
+    })();
+  }
+
   mainWindow.once("ready-to-show", () => {
     // Fill the display work area by default (fresh install, after update, new window).
     try {

app/windows/hsp-app-process.ps1

@@ -1,4 +1,4 @@
-# Used by installer-hooks.nsi (ExecWait -File). Sync process names with package.json:
+# Used by installer-hooks.nsi (nsExec::Exec, no console). Sync process names with package.json:
 # build.productName, name (npm), product-brand portable slug, legacy "Hyperlinks Space App".
 param(
   [Parameter(Mandatory = $true)]

app/windows/installer-hooks.nsi

@@ -131,16 +131,23 @@ Function HspClearEnvInstDir
   System::Call 'kernel32::SetEnvironmentVariable(t, i) ("HSP_INSTDIR", 0)'
 FunctionEnd
 
-; PowerShell: -WindowStyle Hidden avoids flashing console windows (ExecWait still waits for exit).
+; PowerShell: use nsExec::Exec (not ExecWait). ExecWait always attaches a console to powershell.exe,
+; which flashes on screen even with -WindowStyle Hidden; nsExec runs the process with no console window.
 Function HspAnyPackagedExeRunning
   Call HspResolvePowerShellExe
   Call HspSetEnvInstDir
   IfFileExists "$PLUGINSDIR\hsp-app-process.ps1" 0 hspAnyExeNoScript
-    ExecWait '"$R5" -NoProfile -NonInteractive -ExecutionPolicy Bypass -WindowStyle Hidden -File "$PLUGINSDIR\hsp-app-process.ps1" -Action Test' $R4
+    nsExec::Exec `"$R5" -NoProfile -NonInteractive -ExecutionPolicy Bypass -File "$PLUGINSDIR\hsp-app-process.ps1" -Action Test`
+    Pop $R4
     Call HspClearEnvInstDir
+    StrCmp $R4 "error" hspAnyExeNsFail
+    StrCmp $R4 "timeout" hspAnyExeNsFail
     IntCmp $R4 0 hspAnyExeYes
     StrCpy $0 0
     Return
+  hspAnyExeNsFail:
+    StrCpy $0 0
+    Return
   hspAnyExeNoScript:
   Call HspClearEnvInstDir
   StrCpy $0 0
@@ -168,7 +175,8 @@ Function HspKillPackagedAppProcesses
   Call HspResolvePowerShellExe
   Call HspSetEnvInstDir
   IfFileExists "$PLUGINSDIR\hsp-app-process.ps1" 0 hspKillNoScript
-    ExecWait '"$R5" -NoProfile -NonInteractive -ExecutionPolicy Bypass -WindowStyle Hidden -File "$PLUGINSDIR\hsp-app-process.ps1" -Action Kill' $R4
+    nsExec::Exec `"$R5" -NoProfile -NonInteractive -ExecutionPolicy Bypass -File "$PLUGINSDIR\hsp-app-process.ps1" -Action Kill`
+    Pop $R4
   hspKillNoScript:
   Call HspClearEnvInstDir
 FunctionEnd
@@ -319,7 +327,7 @@ hspCustomInstallAfterLaunch:
   !insertmacro HspAppendInstallerLog "[uninstaller] complete"
 !macroend
 
-; Runs before Section install (electron-builder prepends this include). Drops helper script for ExecWait -File.
+; Runs before Section install (electron-builder prepends this include). Drops helper script for nsExec::Exec -File.
 ; Use BUILD_RESOURCES_DIR so makensis finds the script when cwd is the NSIS cache dir (Forge/CI).
 !ifndef BUILD_UNINSTALLER
 Section "-hsp_app_process_ps1"