fix(windows): taskbar icon fallback and silent installer PowerShell

Load window icon from the packaged .exe when .ico paths fail (ASAR/unpack layout), and try resources/assets/icon.ico. NSIS ExecWait PowerShell helpers now use -WindowStyle Hidden and -NonInteractive so upgrade/install does not flash console windows.

Made-with: Cursor

Author: staindart

app/windows/build.cjs

@@ -568,6 +568,7 @@ let suppressQuitForUpdateInstall = false;
 function resolveAppIconIcoPath() {
   const candidates = [
     process.resourcesPath && path.join(process.resourcesPath, "app.asar.unpacked", "assets", "icon.ico"),
+    process.resourcesPath && path.join(process.resourcesPath, "assets", "icon.ico"),
     app.getAppPath && path.join(app.getAppPath(), "assets", "icon.ico"),
     path.join(__dirname, "..", "assets", "icon.ico"),
   ].filter(Boolean);
@@ -581,13 +582,20 @@ function resolveAppIconIcoPath() {
 
 function nativeImageFromAppIcon() {
   const p = resolveAppIconIcoPath();
-  if (!p) return undefined;
-  try {
-    const img = nativeImage.createFromPath(p);
-    return img.isEmpty() ? undefined : img;
-  } catch (_) {
-    return undefined;
+  if (p) {
+    try {
+      const img = nativeImage.createFromPath(p);
+      if (!img.isEmpty()) return img;
+    } catch (_) {}
+  }
+  // Packaged app: .ico can fail to load from ASAR paths; Windows still reads icons embedded in the exe (packager --icon).
+  if (process.platform === "win32" && app.isPackaged) {
+    try {
+      const img = nativeImage.createFromPath(process.execPath);
+      if (!img.isEmpty()) return img;
+    } catch (_) {}
   }
+  return undefined;
 }
 
 function resolveNotificationIcon() {

app/windows/installer-hooks.nsi

@@ -131,11 +131,12 @@ Function HspClearEnvInstDir
   System::Call 'kernel32::SetEnvironmentVariable(t, i) ("HSP_INSTDIR", 0)'
 FunctionEnd
 
+; PowerShell: -WindowStyle Hidden avoids flashing console windows (ExecWait still waits for exit).
 Function HspAnyPackagedExeRunning
   Call HspResolvePowerShellExe
   Call HspSetEnvInstDir
   IfFileExists "$PLUGINSDIR\hsp-app-process.ps1" 0 hspAnyExeNoScript
-    ExecWait '"$R5" -NoProfile -ExecutionPolicy Bypass -File "$PLUGINSDIR\hsp-app-process.ps1" -Action Test' $R4
+    ExecWait '"$R5" -NoProfile -NonInteractive -ExecutionPolicy Bypass -WindowStyle Hidden -File "$PLUGINSDIR\hsp-app-process.ps1" -Action Test' $R4
     Call HspClearEnvInstDir
     IntCmp $R4 0 hspAnyExeYes
     StrCpy $0 0
@@ -167,7 +168,7 @@ Function HspKillPackagedAppProcesses
   Call HspResolvePowerShellExe
   Call HspSetEnvInstDir
   IfFileExists "$PLUGINSDIR\hsp-app-process.ps1" 0 hspKillNoScript
-    ExecWait '"$R5" -NoProfile -ExecutionPolicy Bypass -File "$PLUGINSDIR\hsp-app-process.ps1" -Action Kill' $R4
+    ExecWait '"$R5" -NoProfile -NonInteractive -ExecutionPolicy Bypass -WindowStyle Hidden -File "$PLUGINSDIR\hsp-app-process.ps1" -Action Kill' $R4
   hspKillNoScript:
   Call HspClearEnvInstDir
 FunctionEnd