feat(helm): support documented config.model for default model - #2360
feat(helm): support documented config.model for default model#2360RahilOp wants to merge 1 commit into
Conversation
Signed-off-by: Syed Ali Abbas Rahil <viperboom0786110@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
WalkthroughThe Helm chart adds standalone and subchart configuration helpers, documents the optional ChangesHelm model configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for holmes-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Fixes #2223
The provider docs show a
config.modelHelm value for setting the default model, but the chart never honored it. This PR wires it up by exporting theMODELenvironment variable on the Holmes pod.Changes:
config: {}tohelm/holmes/values.yamlwith a usage comment.holmes.configandholmes.config.modelhelpers in_helpers.tplthat support both standaloneconfig.modeland subchartholmes.config.modelvalue paths.templates/holmes.yaml, emit aMODELenv var whenconfig.modelis set.No-op when
config.modelis unset. Users can continue usingadditionalEnvVarswithMODELif they prefer.Verified:
helm lint helm/holmespasses.helm templatewithconfig.modelrendersMODEL=gemini-flash.helm templatewithoutconfig.modelomits theMODELenv var.helm templatewith subchart-styleholmes.config.modelalso rendersMODELcorrectly.Summary by CodeRabbit
New Features
Bug Fixes