Skip to content

feat(helm): support documented config.model for default model - #2360

Open
RahilOp wants to merge 1 commit into
HolmesGPT:masterfrom
RahilOp:feat/2223-helm-config-model
Open

feat(helm): support documented config.model for default model#2360
RahilOp wants to merge 1 commit into
HolmesGPT:masterfrom
RahilOp:feat/2223-helm-config-model

Conversation

@RahilOp

@RahilOp RahilOp commented Aug 6, 2026

Copy link
Copy Markdown

Fixes #2223

The provider docs show a config.model Helm value for setting the default model, but the chart never honored it. This PR wires it up by exporting the MODEL environment variable on the Holmes pod.

Changes:

  • Added config: {} to helm/holmes/values.yaml with a usage comment.
  • Added holmes.config and holmes.config.model helpers in _helpers.tpl that support both standalone config.model and subchart holmes.config.model value paths.
  • In templates/holmes.yaml, emit a MODEL env var when config.model is set.
  • Included the config value in the pod checksum annotation so changing the default model triggers a rollout.

No-op when config.model is unset. Users can continue using additionalEnvVars with MODEL if they prefer.

Verified:

  • helm lint helm/holmes passes.
  • helm template with config.model renders MODEL=gemini-flash.
  • helm template without config.model omits the MODEL env var.
  • helm template with subchart-style holmes.config.model also renders MODEL correctly.

Summary by CodeRabbit

  • New Features

    • Added Helm configuration support for selecting an optional default model.
    • Supports configuration when Holmes is deployed independently or as a subchart.
    • Automatically applies the selected model to the deployment when configured.
  • Bug Fixes

    • Deployment updates now correctly reflect changes to Holmes configuration.

Signed-off-by: Syed Ali Abbas Rahil <viperboom0786110@gmail.com>

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 537894ea-f807-48e0-901d-5e31a6b08397

📥 Commits

Reviewing files that changed from the base of the PR and between 10b772b and 7ae9008.

📒 Files selected for processing (3)
  • helm/holmes/templates/_helpers.tpl
  • helm/holmes/templates/holmes.yaml
  • helm/holmes/values.yaml

Walkthrough

The Helm chart adds standalone and subchart configuration helpers, documents the optional config.model value, includes rendered configuration in the pod checksum, and exports the configured model through the MODEL environment variable.

Changes

Helm model configuration

Layer / File(s) Summary
Configuration helpers and values
helm/holmes/values.yaml, helm/holmes/templates/_helpers.tpl
The chart adds an optional config.model value. Helpers render standalone or subchart configuration and retrieve the configured model.
Deployment configuration wiring
helm/holmes/templates/holmes.yaml
The pod checksum includes rendered configuration. The container sets MODEL when a model value is configured.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: roiglinik, aantn

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes Helm support for the documented config.model default model setting.
Linked Issues check ✅ Passed The changes implement config.model support for standalone and subchart values, set MODEL, and trigger rollouts when configuration changes [#2223].
Out of Scope Changes check ✅ Passed All described changes directly support the linked issue and PR objectives; no unrelated code changes are identified.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@netlify

netlify Bot commented Aug 6, 2026

Copy link
Copy Markdown

Deploy Preview for holmes-docs ready!

Name Link
🔨 Latest commit 7ae9008
🔍 Latest deploy log https://app.netlify.com/projects/holmes-docs/deploys/6a73d9f8960225000877336f
😎 Deploy Preview https://deploy-preview-2360--holmes-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Helm chart does not support documented config.model for setting default model

1 participant