RdmpCohortBuildHealthBoardBreakdown plugin package (9.2.3) by mtinti · Pull Request #2368 · HicServices/RDMP

mtinti · 2026-07-01T14:33:43Z

Proposed Change

Adds a self-contained package for the RdmpCohortBuildHealthBoardBreakdown plugin (RDMP 9.2.3), under
the new top-level RdmpCohortBuildHealthBoardBreakdown/ folder: the built .rdmp plugin, its source,
and install/usage notes. It ships the built plugin (for review and installation) rather than a
Rdmp.Core code merge; the full source is included under src/.

What the plugin does: reproduces the Cohort Builder's per-set / per-container count tree (the
FinalCount and cumulative running totals shown as UNION/INTERSECT/EXCEPT are applied), split by
Scottish health board, plus the unfiltered national total, as a wide CSV.

How it works: it builds the cohort once (which populates RDMP's query cache), then recomposes every
count point purely from the cached per-set identifier tables and splits each by
SHARE_Demography.Region with one GROUP BY per node. There is no per-board rebuild, and no
source-catalogue hits after the single build (so it is cross-server safe). It requires a query-caching
server, and the demography catalogue on the same server as the cache.

Output: a wide CSV. One row per count point (name written once), a Metric column (Final and
Cumulative), a Total column (national), one column per Scottish board, then Other (present
non-Scottish or unmapped region codes) and NotKnown (not in demography, or null region). The column
header is repeated above a % of final cohort row. Boards plus Other plus NotKnown reconcile to Total
on every row.

Contents (RdmpCohortBuildHealthBoardBreakdown/): RdmpCohortBuildHealthBoardBreakdown.rdmp,
README.md, INSTALL.md, and src/ (command, report, health-board lookup, UI hook, csproj, nuspec).

Validation: verified end-to-end against a deterministic synthetic fixture (a top EXCEPT over an
inclusion INTERSECT minus four exclusion sets, with the cohort partitioned across 3 boards). Every
national and per-board count and cumulative is asserted cell-by-cell, the unfiltered column equals
RDMP's own CohortCompiler counts, and the boards sum to national at every node.

Type of change

Bugfix (non-breaking change which fixes an issue)
New Feature (non-breaking change which adds functionality)
Breaking Change (fix or feature that would cause existing functionality to not work as expected)
Documentation-Only Update
Other (if none of the other choices apply)

Checklist

By opening this PR, I confirm that I have:

Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able). Additive (one new folder).
Created or updated any tests if relevant. NUnit unit and DB-integration tests exist with the source (Rdmp.Core.Tests), validated against the fixture described in the source.
Have validated this change against the Test Plan. Validated against the deterministic synthetic fixture instead.
Requested a review by one of the repository maintainers. Draft, opened for visibility.
Have written new documentation or updated existing documentation to detail any new or updated functionality and how to use it (README.md, INSTALL.md).
Have added an entry into the changelog. Not applicable for this plugin-package PR.

Self-contained package for the cohort-build health-board breakdown plugin: the built .rdmp, install/usage notes, plugin source, and design + technical documentation. Splits the Cohort Builder's per-step count tree by Scottish health board (wide CSV: Metric, Total, per-board columns, Other, NotKnown, and a % of final cohort row). Cache-only recompose, validated against a deterministic synthetic fixture. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0169JCnaL3fhhZjseDx2XXT2

Keep the package to the built .rdmp + INSTALL + README + source. Design and technical docs remain on the proposals branch. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0169JCnaL3fhhZjseDx2XXT2

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0169JCnaL3fhhZjseDx2XXT2

JFriel

I think this change would be a better tagret for a plugin, rather than core RDMP. Can discuss HIC owned plugins via teams

JFriel · 2026-07-02T14:11:44Z

+
+namespace RdmpCohortBuildHealthBoardBreakdown;
+
+public class CohortBuildHealthBoardBreakdownPluginUserInterface : PluginUserInterface


The PluginUserInterface is really for use by plugins, not code that has access to the RDMP internals. If this is something you want to keep as a plugin, it may be best to create it as a standalone outside of the RDMP codebase, or target the chodechange against the HIC specific Plugin Codebase (can share seperatly). If you want to keep in in core RDMP, this functionality is best moved to the ContetxStripMenu or the standard RightClick options function

JFriel · 2026-07-02T14:20:18Z

@@ -0,0 +1,24 @@
+// Surfaces the cohort build health board breakdown in the RDMP desktop GUI (right-click a cohort


This file should be in the existing directory structure. Something like RDMP.Core/CohortCreation/Aggregates or similar

JFriel · 2026-07-02T14:23:38Z

+    public const string PercentMetric = "% of final cohort";
+
+    /// <summary>One count point of the build tree with its per-region counts (known boards only).</summary>
+    public sealed class NodeBreakdown


Can you put these nested classes into their own file

JFriel · 2026-07-02T14:26:28Z

+        CohortIdentificationConfiguration cic,
+        [DemandsInitialization("CSV file to write. Defaults to <cic>-build-healthboard.csv in the current directory")]
+        FileInfo toFile = null,
+        [DemandsInitialization("Demography catalogue holding the region column", DefaultValue = "SHARE_Demography")]


Cant use this as a default value in the RDMP codebase. Probably shouldn't have a default value

JFriel · 2026-07-02T14:27:23Z

+    private readonly Dictionary<int, (string fqn, string col)> _setCacheTable = new();
+    private readonly Dictionary<(bool isContainer, int id), (int final, int? cumulative)> _baseline = new();
+
+    public ExecuteCommandExportCohortBuildHealthBoardBreakdown(IBasicActivateItems activator,


Is it worth making this more geenric i.e. ExportCohortBuildBreakDownByGroups or similar

JFriel · 2026-07-02T14:29:31Z

+        CohortIdentificationConfiguration cic,
+        [DemandsInitialization("CSV file to write. Defaults to <cic>-build-healthboard.csv in the current directory")]
+        FileInfo toFile = null,
+        [DemandsInitialization("Demography catalogue holding the region column", DefaultValue = "SHARE_Demography")]


This should pass in a catalogue, not a string. It can also be mapped from the cli like Catalogue:1234

JFriel · 2026-07-02T14:29:52Z

+        [DemandsInitialization("Demography catalogue holding the region column", DefaultValue = "SHARE_Demography")]
+        string demographyCatalogue = "SHARE_Demography",
+        [DemandsInitialization("Region (health board cipher) column on the demography catalogue", DefaultValue = "Region")]
+        string regionColumn = "Region",


This should pass in a ColumnInfo

JFriel · 2026-07-02T14:39:14Z

+        if (parent != null && indexInParent > 0 && cCum.HasValue)
+            cCumByRegion = RunRegionCounts(CumulativeSql(parent, indexInParent));
+
+        nodes.Add(new CohortBuildHealthBoardBreakdownReport.NodeBreakdown


You can add a constructor to nodebreakdown that maps the key/values rather than have to manually map them here and further down

JFriel · 2026-07-02T14:40:16Z

+
+    private IReadOnlyDictionary<string, int> RunRegionCounts(string idListSql)
+    {
+        var sql =


RMDP supports multible db types (sql,postgres,oracle). This SQL will need to be rewritten using FansiSQL

JFriel · 2026-07-02T14:41:14Z

+    public const string UnknownNode = "Unknown";
+
+    // keyed by the single-letter Region cipher held in SHARE_Demography.Region
+    private static readonly Dictionary<string, HealthBoard> ByRegion = new(System.StringComparer.OrdinalIgnoreCase)


This should not be in RMDP and if something like this is required, it should reference a user-defined lookup

mtinti mentioned this pull request Jul 1, 2026

Add cohort health board breakdown commands (final-list + build tree) #2367

Closed

11 tasks

mtinti and others added 2 commits July 1, 2026 15:41

Use plain punctuation in the package README (drop em-dashes)

3e99c20

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0169JCnaL3fhhZjseDx2XXT2

mtinti marked this pull request as ready for review July 1, 2026 20:39

JFriel requested changes Jul 7, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

RdmpCohortBuildHealthBoardBreakdown plugin package (9.2.3)#2368

RdmpCohortBuildHealthBoardBreakdown plugin package (9.2.3)#2368
mtinti wants to merge 3 commits into
HicServices:developfrom
mtinti:release/RdmpCohortBuildHealthBoardBreakdown

mtinti commented Jul 1, 2026 •

edited

Loading

Uh oh!

JFriel left a comment

Uh oh!

JFriel Jul 2, 2026

Uh oh!

JFriel Jul 2, 2026

Uh oh!

JFriel Jul 2, 2026

Uh oh!

JFriel Jul 2, 2026

Uh oh!

JFriel Jul 2, 2026

Uh oh!

JFriel Jul 2, 2026

Uh oh!

JFriel Jul 2, 2026

Uh oh!

JFriel Jul 2, 2026

Uh oh!

JFriel Jul 2, 2026

Uh oh!

JFriel Jul 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants


		namespace RdmpCohortBuildHealthBoardBreakdown;

		public class CohortBuildHealthBoardBreakdownPluginUserInterface : PluginUserInterface

		@@ -0,0 +1,24 @@
		// Surfaces the cohort build health board breakdown in the RDMP desktop GUI (right-click a cohort

Uh oh!

Conversation

mtinti commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed Change

Type of change

Checklist

Uh oh!

JFriel left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mtinti commented Jul 1, 2026 •

edited

Loading