Skip to content

Add configurable allowed directory for applications with 'any' option #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kriszyp merged 1 commit into from
Apr 24, 2026
+6 −1
Merged

Add configurable allowed directory for applications with 'any' option #401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions components/ApplicationScope.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ export class ApplicationScope {

this.mode = env.get(CONFIG_PARAMS.APPLICATIONS_MODULELOADER) ?? 'vm';
this.dependencyLoader = env.get(CONFIG_PARAMS.APPLICATIONS_DEPENDENCYLOADER);
if (env.get(CONFIG_PARAMS.APPLICATIONS_ALLOWEDDIRECTORY) !== 'app') this.allowedPath = ''; // this is used to match paths by startsWith, so empty string matches everything
}

/**
Expand Down
1 change: 1 addition & 0 deletions static/defaultConfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ applications:
allowedSpawnCommands:
- npm
- node
allowedDirectory: app
componentsRoot: null
localStudio:
enabled: true
Expand Down
1 change: 1 addition & 0 deletions utility/hdbTerms.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,6 +442,7 @@ export const CONFIG_PARAMS = {
APPLICATIONS_PACKAGEMANAGERPREFIX: 'applications_packageManagerPrefix',
APPLICATIONS_ALLOWEDBUILTINMODULES: 'applications_allowedBuiltInModules',
APPLICATIONS_ALLOWEDSPAWNCOMMANDS: 'applications_allowedSpawnCommands',
APPLICATIONS_ALLOWEDDIRECTORY: 'applications_allowedDirectory',
THREADS: 'threads',
THREADS_COUNT: 'threads_count',
THREADS_DEBUG: 'threads_debug',
Expand Down
4 changes: 3 additions & 1 deletion utility/install/installer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ const DEV_MODE_CONFIG = {
[CONFIG_PARAMS.OPERATIONSAPI_NETWORK_PORT]: 9925,
[CONFIG_PARAMS.LOCALSTUDIO_ENABLED]: true,
[CONFIG_PARAMS.NODE_HOSTNAME]: DEFAULT_NODE_HOSTNAME,
[CONFIG_PARAMS.APPLICATIONS_ALLOWEDDIRECTORY]: 'any',
};

// Install prompts
Expand Down Expand Up @@ -110,7 +111,8 @@ async function install() {

// REPLICATION_HOSTNAME was renamed to NODE_HOSTNAME in v5, but we still support the replication value if provided
if (promptOverride[hdbTerms.INSTALL_PROMPTS.REPLICATION_HOSTNAME]) {
promptOverride[hdbTerms.INSTALL_PROMPTS.NODE_HOSTNAME] = promptOverride[hdbTerms.INSTALL_PROMPTS.REPLICATION_HOSTNAME];
promptOverride[hdbTerms.INSTALL_PROMPTS.NODE_HOSTNAME] =
promptOverride[hdbTerms.INSTALL_PROMPTS.REPLICATION_HOSTNAME];
}

// For backwards compatibility for a time before DEFAULTS_MODE (and host name) assume prod when these args used
Expand Down
Loading