Skip to content

Reset the event timer when resuming from a paused breakpoint #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kriszyp wants to merge 2 commits into
base: main
Choose a base branch
from
+18 −0
Open

Reset the event timer when resuming from a paused breakpoint #356

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0adc270
Reset the event timer when resuming from a paused breakpoint
kriszyp Apr 15, 2026
a3fec71
Update server/throttle.ts
kriszyp Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions server/throttle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { logger } from '../utility/logging/logger.ts';
import { Session, url as inspectorURL } from 'inspector';
Comment thread
kriszyp marked this conversation as resolved.
Outdated
const MAX_EVENT_DELAY_TIME = 3000;
const DEFAULT_MAX_QUEUE_TIME = 20_000; // 20 seconds
let lastWarning = 0;
Expand Down Expand Up @@ -71,3 +72,20 @@ setInterval(() => {
}
lastEventQueueCheck = now;
}, EVENT_QUEUE_MONITORING_INTERVAL).unref();

// Reset lastEventQueueCheck if we are resuming from the debugger
// so the event loop lag check ignores breakpoint pauses
setTimeout(() => {
// wait for any debugger to register and then see if the inspector/debugger is actually enabled
if (inspectorURL()) {
const session = new Session();
session.connect();
session.post('Debugger.enable');
session.on('inspectorNotification', ({ method }) => {
if (method === 'Debugger.resumed') {
// reset if we are resuming
lastEventQueueCheck = performance.now();
}
});
}
}, 1);
Loading