Draft
Conversation
cb1kenobi
approved these changes
Apr 6, 2026
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
Author
|
This breaks the unit tests for mqtt, so we need to adapt the code with the v4 -> v5 breaking changes |
dawsontoth
force-pushed
the
mqtt-v5
branch
2 times, most recently
from
4f6283d to
a213184
Compare
Contributor
Author
|
I did the simple update, then let AI play with it for a bit, but I don't like the looks of what it's generating with the changes to the unit tests. I'd love it if someone with more knowledge of our MQTT testing took a look at this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.