Deflake caching test 'Can load cached indexed data'#242
Draft
Ethan-Arrowood wants to merge 3 commits intomainfrom
Draft
Deflake caching test 'Can load cached indexed data'#242Ethan-Arrowood wants to merge 3 commits intomainfrom
'Can load cached indexed data'#242Ethan-Arrowood wants to merge 3 commits intomainfrom
Conversation
Member
Author
|
Related to #239 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test file unitTests/resources/caching.test.js has been flaky on harper CI, I’ve noticed it in multiple PR CI runs recently.
“TypeError: result.getExpiresAt is not a function”“AssertionError 3 == 2”Can reproduce locally using:
The
“TypeError: result.getExpiresAt is not a function”is easy to solve as we can just remove the last two lines that have no impact on the actual test:But the other error is more difficult. Bumping the timeout to 20ms didn't work, and mocha explicitly recommends avoiding using 1this.retries()` for unit tests. I'm really looking for a more deterministic solution here, or potentially a deep dive into why this specific circumstance is flaky when other tests in this file are not. This test file makes have use of timers so why is only this test flaking?