feat: add NPC button to the Set Initiative screen#344
Merged
Conversation
Allows the DM to add NPCs on the fly before combat starts, without having to enter the live tracker first. The existing AddNpc drawer (basic stats + copy full NPC) is reused unchanged except for collapsing its two submit buttons into a single "Add" when round === 0 (no "next round" concept before combat has started). The button is disabled in test mode, matching the Targets pane.
HarmlessHarm
force-pushed
the
feature/add-npc-on-initiative-screen
branch
from
57bd252 to
f5103a4
Compare
|
HarmlessHarm
pushed a commit
that referenced
this pull request
Jul 7, 2026
Brings in NPC groups, campaign view refactor (#341), DM screen splitter persistence (#339), Set Initiative NPC button (#344), and monster filter changes (#345), re-expressed in Vue 3 syntax where main's code still used Vue 2 patterns: - slot="x" attributes -> v-slot templates (NpcGroupManager, BasicInfo, Npcs, Entities dialogs) - $set/$delete/Vue.set/Vue.delete -> direct assignment (npcGroups and npcs store modules, hk-filter, Entities, BasicInfo) - vue-snotify -> Quasar notify utils (NpcGroupManager, Entities, Npcs) - vee-validate v3 slot props -> v4 errorMessage API (BasicInfo) - QTable :data -> :rows; () => import() -> defineAsyncComponent - process.browser -> typeof window guard in browserDetect (app failed to boot server- and client-side otherwise) - adopted main's boot/prototypes.js (server-enabled for SSR) Additionally fixes a latent Quasar v2 event-contract gap the merge review surfaced: 101 @input handlers and 43 :value bindings on Quasar form components renamed to @update:model-value / :model-value (Quasar v2 components no longer emit input or read value; the handlers were dead and several bindings one-way only). Verified: SPA + SSR builds pass; headless audit of 10 routes renders with zero Vue warnings. https://claude.ai/code/session_013pNZHMppjJ2iGVjxjHKkpQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AddNpcdrawerAddNpcdrawer now shows a single Add button (instead of "Add next round" / "Add directly") when the encounter hasn't started yet (round === 0), since the "next round" concept doesn't apply before combat beginsTest plan