frameworks/base: ignore invalid handle in android_getaddrinfofornetwork#79
Open
NotKit wants to merge 1 commit into
Open
frameworks/base: ignore invalid handle in android_getaddrinfofornetwork#79NotKit wants to merge 1 commit into
NotKit wants to merge 1 commit into
Conversation
Since we fallback to host systemd-resolved in bionic, specifying network ID doesn't make sense anyway and we can use NETID_UNSET.
ElectrodeYT
approved these changes
Apr 19, 2024
ElectrodeYT
left a comment
There was a problem hiding this comment.
LGTM; although I do still wonder if simply replacing the entire function with something along the lines of return android_getaddrinfofornet(node, service, hints, NETID_UNSET, MARK_UNSET, res); would work as well? I don't know if this function will ever see a valid net handle, which would make the check needless
Would technically save a needless if statement, but I doubt that this gets called enough for that branch to be even close to wasting performance lol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we fallback to host systemd-resolved in bionic, specifying network ID doesn't make sense anyway and we can use NETID_UNSET.