Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ LOCAL_INCLUDE_PATHS =

# specify the level of optimization that you desire
# NONE, SOME, FULL
OPTIMIZE=
OPTIMIZE= FULL

# specify here the codes for languages you are going
# to support in this application. The default "en"
Expand All @@ -143,7 +143,7 @@ DEFINES=
# if unspecified default warnings will be used
# NONE = supress all warnings
# ALL = enable all warnings
WARNINGS =
WARNINGS = ALL

# specify whether image symbols will be created
# so that stack crawls in the debugger are meaningful
Expand All @@ -156,7 +156,7 @@ SYMBOLS =
DEBUGGER =

# specify additional compiler flags for all files
COMPILER_FLAGS =
COMPILER_FLAGS = -Werror

# specify additional linker flags
LINKER_FLAGS =
Expand Down
6 changes: 3 additions & 3 deletions addons/AddOns/AdaptiveHistogramEqualization/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ LOCAL_INCLUDE_PATHS = ${Addon-Includes}

# Specify the level of optimization that you want. Specify either NONE (O0),
# SOME (O1), FULL (O2), or leave blank (for the default optimization level).
OPTIMIZE :=
OPTIMIZE := FULL

# Specify the codes for languages you are going to support in this
# application. The default "en" one must be provided too. "make catkeys"
Expand All @@ -110,7 +110,7 @@ DEFINES =

# Specify the warning level. Either NONE (suppress all warnings),
# ALL (enable all warnings), or leave blank (enable default warnings).
WARNINGS =
WARNINGS = ALL

# With image symbols, stack crawls in the debugger are meaningful.
# If set to "TRUE", symbols will be created.
Expand All @@ -121,7 +121,7 @@ SYMBOLS :=
DEBUGGER :=

# Specify any additional compiler flags to be used.
COMPILER_FLAGS =
COMPILER_FLAGS = -Werror

# Specify any additional linker flags to be used.
LINKER_FLAGS =
Expand Down
3 changes: 0 additions & 3 deletions addons/AddOns/AntiDitherer/AntiDitherer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -155,9 +155,6 @@ AntiDithererManipulator::anti_dither()
if (selection != NULL && selection->IsEmpty() == false)
bounds = selection->GetBoundingRect();

int32 width = bounds.IntegerWidth();
int32 height = bounds.IntegerHeight();

float bounds_left = bounds.left;
float bounds_right = bounds.right;
float bounds_top = bounds.top;
Expand Down
6 changes: 3 additions & 3 deletions addons/AddOns/AntiDitherer/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ LOCAL_INCLUDE_PATHS = ${Addon-Includes}

# Specify the level of optimization that you want. Specify either NONE (O0),
# SOME (O1), FULL (O2), or leave blank (for the default optimization level).
OPTIMIZE :=
OPTIMIZE := FULL

# Specify the codes for languages you are going to support in this
# application. The default "en" one must be provided too. "make catkeys"
Expand All @@ -110,7 +110,7 @@ DEFINES =

# Specify the warning level. Either NONE (suppress all warnings),
# ALL (enable all warnings), or leave blank (enable default warnings).
WARNINGS =
WARNINGS = ALL

# With image symbols, stack crawls in the debugger are meaningful.
# If set to "TRUE", symbols will be created.
Expand All @@ -121,7 +121,7 @@ SYMBOLS :=
DEBUGGER :=

# Specify any additional compiler flags to be used.
COMPILER_FLAGS =
COMPILER_FLAGS = -Werror

# Specify any additional linker flags to be used.
LINKER_FLAGS =
Expand Down
4 changes: 0 additions & 4 deletions addons/AddOns/Blur/Blur.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -94,10 +94,6 @@ BlurManipulator::ManipulateBitmap(
return NULL;
}

BBitmap* source_bitmap;
BBitmap* target_bitmap;
BBitmap* new_bitmap = NULL;

return original;
}

Expand Down
6 changes: 3 additions & 3 deletions addons/AddOns/Blur/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ LOCAL_INCLUDE_PATHS = ${Addon-Includes}

# Specify the level of optimization that you want. Specify either NONE (O0),
# SOME (O1), FULL (O2), or leave blank (for the default optimization level).
OPTIMIZE :=
OPTIMIZE := FULL

# Specify the codes for languages you are going to support in this
# application. The default "en" one must be provided too. "make catkeys"
Expand All @@ -110,7 +110,7 @@ DEFINES =

# Specify the warning level. Either NONE (suppress all warnings),
# ALL (enable all warnings), or leave blank (enable default warnings).
WARNINGS =
WARNINGS = ALL

# With image symbols, stack crawls in the debugger are meaningful.
# If set to "TRUE", symbols will be created.
Expand All @@ -121,7 +121,7 @@ SYMBOLS :=
DEBUGGER :=

# Specify any additional compiler flags to be used.
COMPILER_FLAGS =
COMPILER_FLAGS = -Werror

# Specify any additional linker flags to be used.
LINKER_FLAGS =
Expand Down
1 change: 0 additions & 1 deletion addons/AddOns/Brightness/Brightness.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,6 @@ BrightnessManipulator::thread_function(int32 thread_number)
float missed_update = 0;

// Loop through all pixels in original.
uint32 sum;
brightness *= 3;
uint8 brighness_array[256];
for (int32 i = 0; i < 256; i++)
Expand Down
6 changes: 3 additions & 3 deletions addons/AddOns/Brightness/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ LOCAL_INCLUDE_PATHS = ${Addon-Includes}

# Specify the level of optimization that you want. Specify either NONE (O0),
# SOME (O1), FULL (O2), or leave blank (for the default optimization level).
OPTIMIZE :=
OPTIMIZE := FULL

# Specify the codes for languages you are going to support in this
# application. The default "en" one must be provided too. "make catkeys"
Expand All @@ -110,7 +110,7 @@ DEFINES =

# Specify the warning level. Either NONE (suppress all warnings),
# ALL (enable all warnings), or leave blank (enable default warnings).
WARNINGS =
WARNINGS = ALL

# With image symbols, stack crawls in the debugger are meaningful.
# If set to "TRUE", symbols will be created.
Expand All @@ -121,7 +121,7 @@ SYMBOLS :=
DEBUGGER :=

# Specify any additional compiler flags to be used.
COMPILER_FLAGS =
COMPILER_FLAGS = -Werror

# Specify any additional linker flags to be used.
LINKER_FLAGS =
Expand Down
6 changes: 3 additions & 3 deletions addons/AddOns/ColorBalance/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ LOCAL_INCLUDE_PATHS = ${Addon-Includes}

# Specify the level of optimization that you want. Specify either NONE (O0),
# SOME (O1), FULL (O2), or leave blank (for the default optimization level).
OPTIMIZE :=
OPTIMIZE := FULL

# Specify the codes for languages you are going to support in this
# application. The default "en" one must be provided too. "make catkeys"
Expand All @@ -110,7 +110,7 @@ DEFINES =

# Specify the warning level. Either NONE (suppress all warnings),
# ALL (enable all warnings), or leave blank (enable default warnings).
WARNINGS =
WARNINGS = ALL

# With image symbols, stack crawls in the debugger are meaningful.
# If set to "TRUE", symbols will be created.
Expand All @@ -121,7 +121,7 @@ SYMBOLS :=
DEBUGGER :=

# Specify any additional compiler flags to be used.
COMPILER_FLAGS =
COMPILER_FLAGS = -Werror

# Specify any additional linker flags to be used.
LINKER_FLAGS =
Expand Down
6 changes: 3 additions & 3 deletions addons/AddOns/ColorReducer/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ LOCAL_INCLUDE_PATHS = ${Addon-Includes}

# Specify the level of optimization that you want. Specify either NONE (O0),
# SOME (O1), FULL (O2), or leave blank (for the default optimization level).
OPTIMIZE :=
OPTIMIZE := FULL

# Specify the codes for languages you are going to support in this
# application. The default "en" one must be provided too. "make catkeys"
Expand All @@ -112,7 +112,7 @@ DEFINES =

# Specify the warning level. Either NONE (suppress all warnings),
# ALL (enable all warnings), or leave blank (enable default warnings).
WARNINGS =
WARNINGS = ALL

# With image symbols, stack crawls in the debugger are meaningful.
# If set to "TRUE", symbols will be created.
Expand All @@ -123,7 +123,7 @@ SYMBOLS :=
DEBUGGER :=

# Specify any additional compiler flags to be used.
COMPILER_FLAGS =
COMPILER_FLAGS = -Werror

# Specify any additional linker flags to be used.
LINKER_FLAGS =
Expand Down
3 changes: 0 additions & 3 deletions addons/AddOns/ColorReducer/color_mapper.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -218,9 +218,6 @@ preserve_solids_fs_color_mapper(BBitmap* inSource, const rgb_color* inPalette, i
int32 width = inSource->Bounds().IntegerWidth();
int32 height = inSource->Bounds().IntegerHeight();

int32 source_padding = source_bpr - width - 1;
int32 destination_padding = destination_bpr - width - 1;

// We use three error arrays and three side error variables.
// The error arrays are a little bit wider than the image to
// avoid cheking for border conditions
Expand Down
4 changes: 2 additions & 2 deletions addons/AddOns/ColorReducer/palette_generator.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ gla_palette(BBitmap* inBitmap, int paletteSize)
list_count++;
}
}
printf("Number of lists is %d, average length %f\n", list_count,
printf("Number of lists is %" B_PRId32 ", average length %f\n", list_count,
total_length / (float)list_count);

// Initialize the palette.
Expand Down Expand Up @@ -218,7 +218,7 @@ gla_palette(BBitmap* inBitmap, int paletteSize)
palette_still_improving = true;
}

printf("Number of iterations %d\n", number_of_iterations);
printf("Number of iterations %" B_PRId32 "\n", number_of_iterations);

delete[] previous_palette;
delete color_metric;
Expand Down
6 changes: 3 additions & 3 deletions addons/AddOns/ColorSeparator/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ LOCAL_INCLUDE_PATHS = ${Addon-Includes}

# Specify the level of optimization that you want. Specify either NONE (O0),
# SOME (O1), FULL (O2), or leave blank (for the default optimization level).
OPTIMIZE :=
OPTIMIZE := FULL

# Specify the codes for languages you are going to support in this
# application. The default "en" one must be provided too. "make catkeys"
Expand All @@ -110,7 +110,7 @@ DEFINES =

# Specify the warning level. Either NONE (suppress all warnings),
# ALL (enable all warnings), or leave blank (enable default warnings).
WARNINGS =
WARNINGS = ALL

# With image symbols, stack crawls in the debugger are meaningful.
# If set to "TRUE", symbols will be created.
Expand All @@ -121,7 +121,7 @@ SYMBOLS :=
DEBUGGER :=

# Specify any additional compiler flags to be used.
COMPILER_FLAGS =
COMPILER_FLAGS = -Werror

# Specify any additional linker flags to be used.
LINKER_FLAGS =
Expand Down
3 changes: 1 addition & 2 deletions addons/AddOns/Contrast/Contrast.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ ContrastManipulator::CalculateAverageLuminance(BBitmap* bitmap)
uint32 word;
} color;

for (int32 i = 0; i < bits_length; i++) {
for (uint32 i = 0; i < bits_length; i++) {
color.word = *bits++;
luminance_sum += 0.299 * color.bytes[0] + 0.587 * color.bytes[1] + 0.144 * color.bytes[2];
}
Expand Down Expand Up @@ -245,7 +245,6 @@ ContrastManipulator::thread_function(int32 thread_number)
float missed_update = 0;

// Loop through all pixels in original.
uint32 sum;
contrast *= 3;
for (int32 y = top; y <= bottom; y += step) {
int32 y_times_source_bpr = y * source_bpr;
Expand Down
6 changes: 3 additions & 3 deletions addons/AddOns/Contrast/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ LOCAL_INCLUDE_PATHS = ${Addon-Includes}

# Specify the level of optimization that you want. Specify either NONE (O0),
# SOME (O1), FULL (O2), or leave blank (for the default optimization level).
OPTIMIZE :=
OPTIMIZE := FULL

# Specify the codes for languages you are going to support in this
# application. The default "en" one must be provided too. "make catkeys"
Expand All @@ -110,7 +110,7 @@ DEFINES =

# Specify the warning level. Either NONE (suppress all warnings),
# ALL (enable all warnings), or leave blank (enable default warnings).
WARNINGS =
WARNINGS = ALL

# With image symbols, stack crawls in the debugger are meaningful.
# If set to "TRUE", symbols will be created.
Expand All @@ -121,7 +121,7 @@ SYMBOLS :=
DEBUGGER :=

# Specify any additional compiler flags to be used.
COMPILER_FLAGS =
COMPILER_FLAGS = -Werror

# Specify any additional linker flags to be used.
LINKER_FLAGS =
Expand Down
6 changes: 3 additions & 3 deletions addons/AddOns/ContrastManipulator/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ LOCAL_INCLUDE_PATHS = ${Addon-Includes}

# Specify the level of optimization that you want. Specify either NONE (O0),
# SOME (O1), FULL (O2), or leave blank (for the default optimization level).
OPTIMIZE :=
OPTIMIZE := FULL

# Specify the codes for languages you are going to support in this
# application. The default "en" one must be provided too. "make catkeys"
Expand All @@ -110,7 +110,7 @@ DEFINES =

# Specify the warning level. Either NONE (suppress all warnings),
# ALL (enable all warnings), or leave blank (enable default warnings).
WARNINGS =
WARNINGS = ALL

# With image symbols, stack crawls in the debugger are meaningful.
# If set to "TRUE", symbols will be created.
Expand All @@ -121,7 +121,7 @@ SYMBOLS :=
DEBUGGER :=

# Specify any additional compiler flags to be used.
COMPILER_FLAGS =
COMPILER_FLAGS = -Werror

# Specify any additional linker flags to be used.
LINKER_FLAGS =
Expand Down
6 changes: 3 additions & 3 deletions addons/AddOns/Dispersion/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ LOCAL_INCLUDE_PATHS = ${Addon-Includes}

# Specify the level of optimization that you want. Specify either NONE (O0),
# SOME (O1), FULL (O2), or leave blank (for the default optimization level).
OPTIMIZE :=
OPTIMIZE := FULL

# Specify the codes for languages you are going to support in this
# application. The default "en" one must be provided too. "make catkeys"
Expand All @@ -111,7 +111,7 @@ DEFINES =

# Specify the warning level. Either NONE (suppress all warnings),
# ALL (enable all warnings), or leave blank (enable default warnings).
WARNINGS =
WARNINGS = ALL

# With image symbols, stack crawls in the debugger are meaningful.
# If set to "TRUE", symbols will be created.
Expand All @@ -122,7 +122,7 @@ SYMBOLS :=
DEBUGGER :=

# Specify any additional compiler flags to be used.
COMPILER_FLAGS =
COMPILER_FLAGS = -Werror

# Specify any additional linker flags to be used.
LINKER_FLAGS =
Expand Down
2 changes: 1 addition & 1 deletion addons/AddOns/EdgeDetector/DetectEdges.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ DetectEdgesManipulator::ManipulateBitmap(BBitmap* original, BStatusBar* status_b
// convolution to work properly.
duplicate = DuplicateBitmap(original, -1);
}
catch (std::bad_alloc e) {
catch (const std::bad_alloc& e) {
// Here we could clean up if there was need for that.
return NULL; // Returning NULL means that the image did not change.
}
Expand Down
Loading