Skip to content

Refactor ImageView drawing to remove checker background from render #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HiCamino wants to merge 1 commit into from
Closed

Refactor ImageView drawing to remove checker background from render #685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 4 additions & 21 deletions artpaint/paintwindow/Image.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1490,28 +1490,11 @@ Image::DoRenderPreview(BRect area, int32 resolution)
int32 right = (int32)area.right;
int32 bottom = (int32)area.bottom;

int32 gridSize;
uint32 color1;
uint32 color2;

gridSize = 20;
rgb_color rgb1, rgb2;
rgb1.red = rgb1.green = rgb1.blue = 0xBB;
rgb2.red = rgb2.green = rgb2.blue = 0x99;
rgb1.alpha = rgb2.alpha = 0xFF;
color1 = RGBColorToBGRA(rgb1);
color2 = RGBColorToBGRA(rgb2);
union color_conversion white_bg;
white_bg.word = 0xFFFFFFFF;
white_bg.bytes[3] = 0x00;

if (SettingsServer* server = SettingsServer::Instance()) {
BMessage settings;
server->GetApplicationSettings(&settings);

gridSize = settings.GetInt32(skBgGridSize, gridSize);
color1 = settings.GetUInt32(skBgColor1, color1);
color2 = settings.GetUInt32(skBgColor2, color2);
}

BitmapUtilities::CheckerBitmap(rendered_image, color1, color2, gridSize, &area);
BitmapUtilities::ClearBitmap(rendered_image, white_bg.word, &area);

for (int32 y = top; y <= bottom; y += resolution) {
for (int32 x = left; x <= right; x += resolution) {
Expand Down
4 changes: 2 additions & 2 deletions artpaint/paintwindow/Image.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,8 @@ class Image {
Image(ImageView*, float, float, UndoQueue*);
~Image();

void Render(bool bg = true);
void Render(BRect, bool bg = true);
void Render(bool bg = false);
void Render(BRect, bool bg = false);
void RenderPreview(BRect, int32);
void RenderPreview(BRegion&, int32);
void MultiplyRenderedImagePixels(int32);
Expand Down
Loading