Skip to content

Improve query parameter in event definition filter query workflow (7.1)#25871

Draft
kingzacko1 wants to merge 1 commit into7.1from
backport-7.1/fix-query-parameters-in-event-definitions
Draft

Improve query parameter in event definition filter query workflow (7.1)#25871
kingzacko1 wants to merge 1 commit into7.1from
backport-7.1/fix-query-parameters-in-event-definitions

Conversation

@kingzacko1
Copy link
Copy Markdown
Contributor

@kingzacko1 kingzacko1 commented May 1, 2026

Note: This is a backport of #25755 to 7.1.

Description

  • Skip dependency resolution of lookup tables, adapters, and caches in DefaultEntityDependencyResolver since they are not included in builtin GRN types (this was preventing Event Definitions with search query parameters from being saved by any user other than local:admin)
  • Prevent executing event definition search preview if there is an undeclared query parameter (unnecessary errors were being thrown in the UI)
  • Properly load newly created query parameters immediately after they are created (attempting to edit them immediately after creation opened a blank modal)

/nocl will include PR in the enterprise CL

Motivation and Context

in conjunction with Graylog2/graylog-plugin-enterprise#13966 fixing lookup table parameters in event definitions

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have requested a documentation update.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

/prd Graylog2/graylog-plugin-enterprise#14133

…5755)

* Improve query parameter in event definition filter query workflow

* Remove unused mock

(cherry picked from commit c614a75)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants