Register graylog-sidecar as Windows service via MSI installer#537
Open
hunterbeach wants to merge 2 commits intoGraylog2:masterfrom
Open
Register graylog-sidecar as Windows service via MSI installer#537hunterbeach wants to merge 2 commits intoGraylog2:masterfrom
hunterbeach wants to merge 2 commits intoGraylog2:masterfrom
Conversation
Add ServiceInstall and ServiceControl elements to the WiX package so the service is registered automatically on install, removing the need to manually run `graylog-sidecar.exe -service install` post-install. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…guring sidecar.yml
|
Hunter Beach seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Author
|
@bernd Can you review this please? I've signed the CLA but the workflow hasn't updated to reflect it. |
Member
|
@hunterbeach I will review it. It will have to wait a bit, though. Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
ServiceInstallto the WiX package so thegraylog-sidecarWindows service is registered automatically during MSI installation, removing the need to manually rungraylog-sidecar.exe -service installpost-install.The service is configured as auto-start under
LocalSystembut is not started during install, allowing the user to populatesidecar.ymlbefore the service runs for the first time.On uninstall, the service is stopped and removed automatically.
These changes were built and tested locally with no issues.
A future feature should be to input the server URL and API key as a installer parameter, similar to how the EXE installer does.
Notes for Reviewers