Skip to content

upgrade activemq to 5.19.2 to match beam#3862

Open
derrickaw wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
derrickaw:20260527_upgradeActiveMQ
Open

upgrade activemq to 5.19.2 to match beam#3862
derrickaw wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
derrickaw:20260527_upgradeActiveMQ

Conversation

@derrickaw

@derrickaw derrickaw commented May 27, 2026

Copy link
Copy Markdown
Contributor

Get partially the way to 6.2 version - #3858

@derrickaw derrickaw added the improvement Making existing code better label May 27, 2026
@codecov

codecov Bot commented May 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.41%. Comparing base (004f4d6) to head (ee6c3f6).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #3862   +/-   ##
=========================================
  Coverage     55.40%   55.41%           
- Complexity     6968     6970    +2     
=========================================
  Files          1103     1103           
  Lines         67539    67539           
  Branches       7574     7574           
=========================================
+ Hits          37423    37426    +3     
+ Misses        27672    27671    -1     
+ Partials       2444     2442    -2     
Components Coverage Δ
spanner-templates 87.79% <ø> (ø)
spanner-import-export 68.66% <ø> (+0.03%) ⬆️
spanner-live-forward-migration 90.22% <ø> (ø)
spanner-live-reverse-replication 82.84% <ø> (ø)
spanner-bulk-migration 92.61% <ø> (ø)
gcs-spanner-dv 89.08% <ø> (ø)
see 2 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@derrickaw derrickaw marked this pull request as ready for review May 28, 2026 01:49
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the ActiveMQ dependency version to 5.19.2. This change is part of a broader effort to modernize the project's dependencies and prepare for future transitions to version 6.x, while ensuring continued compatibility with the existing messaging API standards used within the templates.

Highlights

  • ActiveMQ Version Upgrade: Upgraded the ActiveMQ dependency version from 5.17.7 to 5.19.2 in the v2/pom.xml file to better align with Apache Beam requirements.
  • Dependency Compatibility: Updated the configuration comments to reflect that version 5.19.2 utilizes JMS 2.0 while maintaining javax.jms compatibility, serving as a bridge toward future 6.x upgrades.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the ActiveMQ dependency version in the pom.xml file from 5.17.7 to 5.19.2, updating the associated comments to explain the compatibility with JMS 2.0 and the future transition requirements for upgrading to 6.x. No review comments were provided for this change.

@derrickaw derrickaw requested a review from Abacn May 28, 2026 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Making existing code better size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant