Add spannerChangeStreamTvfNameList parameters for 3 change stream templates#3838
Add spannerChangeStreamTvfNameList parameters for 3 change stream templates#3838tianz101 wants to merge 3 commits into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new configuration parameter, Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates Beam dependencies to version 2.74.0 and introduces a new spannerChangeStreamTvfNameList parameter to the Spanner change stream templates for BigQuery, GCS, and Pub/Sub. This allows for querying and unioning multiple TVF names. Feedback includes correcting a recurring typo ('glound' to 'Google Cloud') in the parameter help text across several files and removing a redundant null check in the BigQuery template logic.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
| optional = true, | ||
| groupName = "Source", | ||
| description = "Colon separated list of change streams TVF names to query and union", | ||
| helpText = "Colon separated list of change streams TVF names to query and union. Note that using colon instead of comma because gcloud does not allow comma in the parameter value.") |
There was a problem hiding this comment.
Why do we need to use gcloud here? In connector codebase, we should not use gcloud.
There was a problem hiding this comment.
The template is typically launched with gcloud command with commannd line arguments.
This is template, not the connector.
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #3838 +/- ##
=============================================
+ Coverage 39.94% 55.53% +15.58%
- Complexity 684 7024 +6340
=============================================
Files 208 1103 +895
Lines 14902 67588 +52686
Branches 1528 7585 +6057
=============================================
+ Hits 5953 37534 +31581
- Misses 8451 27639 +19188
- Partials 498 2415 +1917
🚀 New features to boost your workflow:
|
2 participants
We are adding spannerChangeStreamTvfNameList paramter to allow users to
specify the change stream to query or the list of tvf names to query.