Skip to content

Bump version to 2.7.0-alpha01 #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gstepniewski-google merged 2 commits into from
Sep 23, 2025
Merged

Bump version to 2.7.0-alpha01 #551

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
423471d
Bump version to 2.7.0-alpha01
adamraine Sep 18, 2025
d218425
bump version
adamraine Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion androidbrowserhelper/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ plugins {
// Before 2.6.1, the version code was unused and was kept at 1.
// This is now being used to report metrics, and should be bumped with
// every version bump.
def VERSION = "2.6.2";
def VERSION = "2.7.0-alpha01";
def VERSION_CODE = 2;
Copy link
Copy Markdown
Contributor Author

@adamraine adamraine Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should VERSION_CODE be bumped for alpha releases?

Copy link
Copy Markdown
Collaborator

@gstepniewski-google gstepniewski-google Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely needs to be bumped, each version name should have a unique corresponding version code so that we get accurate metrics.
I don't think we need to follow the rule for apps (where you can't install a lower version code package over a higher one), but maybe it's a good idea to follow it anyway and use something like 2070001?

Copy link
Copy Markdown
Contributor Author

@adamraine adamraine Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2070001

Not sure what the format is here. Is the 0 between 2 and 7 just a delimiter?

For now, I would prefer to just bump to 3 if there isn't a pressing need to establish a format.

Copy link
Copy Markdown
Collaborator

@gstepniewski-google gstepniewski-google Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My reasoning was two digits per version number, i.e. "02.07.00.01" but without the dots and the leading zero... but I'm probably overengineering at this point, let's just bump it to 3 as you're saying.


android {
Expand Down