Skip to content

[v4] Support predefined filters in ChannelListQuery #4120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
laevandus merged 4 commits into from
Jun 3, 2026

Whitespace issue

39b67d7
Select commit
Loading
Failed to load commit list.
Merged

[v4] Support predefined filters in ChannelListQuery #4120

Whitespace issue
39b67d7
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Jun 3, 2026 in 9m 58s

Quality Gate passed

Issues
129 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 39 in Sources/StreamChat/Controllers/ChannelWatcherListController/ChatChannelWatcherListController+SwiftUI.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "changes" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swift&issues=AZ6It86oxd6poH0YmJbG&open=AZ6It86oxd6poH0YmJbG&pullRequest=4120

Check warning on line 38 in Sources/StreamChat/Controllers/MemberController/MemberController+SwiftUI.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "controller" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swift&issues=AZ6It880xd6poH0YmJbT&open=AZ6It880xd6poH0YmJbT&pullRequest=4120

Check failure on line 65 in Sources/StreamChat/WebSocketClient/Engine/URLSessionWebSocketEngine.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this closure is empty, or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swift&issues=AZ6It9A7xd6poH0YmJbo&open=AZ6It9A7xd6poH0YmJbo&pullRequest=4120

Check warning on line 46 in Sources/StreamChat/Controllers/MessageController/MessageController+SwiftUI.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "change" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swift&issues=AZ6It88Hxd6poH0YmJbP&open=AZ6It88Hxd6poH0YmJbP&pullRequest=4120

Check failure on line 194 in Sources/StreamChat/Workers/Background/AttachmentQueueUploader.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this closure is empty, or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swift&issues=AZ6It9FPxd6poH0YmJcV&open=AZ6It9FPxd6poH0YmJcV&pullRequest=4120

Check warning on line 16 in Sources/StreamChat/APIClient/Endpoints/Payloads/RawJSON.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove backticks (`) from "nil" and rename it. 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swift&issues=AZ6It9Maxd6poH0YmJcf&open=AZ6It9Maxd6poH0YmJcf&pullRequest=4120

Check warning on line 60 in Sources/StreamChat/Utils/Logger/Destination/LogDestination.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "showFileName" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swift&issues=AZ6It9Cyxd6poH0YmJcC&open=AZ6It9Cyxd6poH0YmJcC&pullRequest=4120

Check warning on line 102 in Sources/StreamChat/Workers/Background/MessageEditor.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 2 closure expressions. 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swift&issues=AZ6It9Fgxd6poH0YmJcW&open=AZ6It9Fgxd6poH0YmJcW&pullRequest=4120

Check warning on line 1977 in Sources/StreamChat/Database/DTOs/MessageDTO.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this empty class, write its code or make it a "protocol". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swift&issues=AZ6It9Ksxd6poH0YmJcd&open=AZ6It9Ksxd6poH0YmJcd&pullRequest=4120

Check warning on line 46 in Sources/StreamChat/Controllers/ChannelController/ChannelController+SwiftUI.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "channel" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swift&issues=AZ6It84Qxd6poH0YmJay&open=AZ6It84Qxd6poH0YmJay&pullRequest=4120

Check warning on line 12 in Sources/StreamChat/WebSocketClient/Engine/WebSocketEngine.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "sessionConfiguration" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swift&issues=AZ6It9Atxd6poH0YmJbm&open=AZ6It9Atxd6poH0YmJbm&pullRequest=4120

Check warning on line 133 in Sources/StreamChat/Utils/Codable+Extensions.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this constant "RFC3339TimezoneWrapper" to match the regular expression ^[a-z][a-zA-Z0-9]*$. 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swift&issues=AZ6It9D3xd6poH0YmJcN&open=AZ6It9D3xd6poH0YmJcN&pullRequest=4120

Check warning on line 295 in Sources/StreamChat/WebSocketClient/WebSocketClient.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this empty class, write its code or make it a "protocol". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swift&issues=AZ6It9BIxd6poH0YmJbx&open=AZ6It9BIxd6poH0YmJbx&pullRequest=4120

Check warning on line 44 in Sources/StreamChat/Controllers/PollController/PollController+SwiftUI.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "pollController" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swift&issues=AZ6It85txd6poH0YmJa-&open=AZ6It85txd6poH0YmJa-&pullRequest=4120

Check warning on line 64 in Sources/StreamChat/Controllers/MessageController/MessageController+SwiftUI.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "reactions" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swift&issues=AZ6It88Hxd6poH0YmJbS&open=AZ6It88Hxd6poH0YmJbS&pullRequest=4120

Check warning on line 40 in Sources/StreamChat/Utils/Atomic.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "_wrappedValue" to match the regular expression ^[a-z][a-zA-Z0-9]*$. 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swift&issues=AZ6It9CMxd6poH0YmJby&open=AZ6It9CMxd6poH0YmJby&pullRequest=4120

Check warning on line 68 in Sources/StreamChat/Utils/Logger/Destination/BaseLogDestination.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "level" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swift&issues=AZ6It9C_xd6poH0YmJcG&open=AZ6It9C_xd6poH0YmJcG&pullRequest=4120

Check warning on line 35 in Sources/StreamChat/Controllers/DatabaseObserver/BackgroundDatabaseObserver.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "_willChangeItems" to match the regular expression ^[a-z][a-zA-Z0-9]*$. 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swift&issues=AZ6It85kxd6poH0YmJa6&open=AZ6It85kxd6poH0YmJa6&pullRequest=4120

Check warning on line 44 in Sources/StreamChat/Controllers/ChannelWatcherListController/ChatChannelWatcherListController+SwiftUI.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "controller" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swift&issues=AZ6It86oxd6poH0YmJbH&open=AZ6It86oxd6poH0YmJbH&pullRequest=4120

Check warning on line 53 in Sources/StreamChat/Utils/Logger/Destination/LogDestination.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "subsystems" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swift&issues=AZ6It9Cyxd6poH0YmJb7&open=AZ6It9Cyxd6poH0YmJb7&pullRequest=4120

Check warning on line 22 in Sources/StreamChat/Query/ChannelListQuery+PredefinedFilter.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove backticks (`) from "operator" and rename it. 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swift&issues=AZ6It9Plxd6poH0YmJcj&open=AZ6It9Plxd6poH0YmJcj&pullRequest=4120

Check warning on line 86 in Sources/StreamChat/Config/Token.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this empty class, write its code or make it a "protocol". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swift&issues=AZ6It9SYxd6poH0YmJco&open=AZ6It9SYxd6poH0YmJco&pullRequest=4120

Check warning on line 174 in Sources/StreamChat/Config/ChatClientConfig.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Update this function so that its implementation is not identical to description on line 170. 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swift&issues=AZ6It9Srxd6poH0YmJcq&open=AZ6It9Srxd6poH0YmJcq&pullRequest=4120

Check warning on line 57 in Sources/StreamChat/Utils/Logger/Destination/LogDestination.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused function parameter "showLevel" or name it "_". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swift&issues=AZ6It9Cyxd6poH0YmJb_&open=AZ6It9Cyxd6poH0YmJb_&pullRequest=4120

Check warning on line 309 in Sources/StreamChat/APIClient/RequestEncoder.swift

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this empty class, write its code or make it a "protocol". 

See more on https://sonarcloud.io/project/issues?id=GetStream_stream-chat-swift&issues=AZ6It9NZxd6poH0YmJch&open=AZ6It9NZxd6poH0YmJch&pullRequest=4120
View more details on SonarQubeCloud