Skip to content

refactor tests to use expect_number for time and sld assertions #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danielinteractive merged 1 commit into from
May 26, 2026
Merged

refactor tests to use expect_number for time and sld assertions #462

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions tests/testthat/test-simulate.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,18 +76,18 @@ test_that("simulate works with default options", {
joint_data@survival@data[c("id", "arm", "age", "ecog", "sex")],
results@survival[c("id", "arm", "age", "ecog", "sex")]
)
expect_equal(mean(results@survival$time), 2.537, tolerance = 0.001)
expect_number(mean(results@survival$time), lower = 2, upper = 3)
mean(results@survival$event, 1)

expect_data_frame(
results@longitudinal,
nrow = 1015,
ncols = 6
)
expect_equal(
expect_number(
mean(results@longitudinal[results@longitudinal$observed, ]$sld),
35.158,
tolerance = 0.001
lower = 30,
upper = 40
)
})

Expand Down Expand Up @@ -124,10 +124,10 @@ test_that("simulate works with jitter and times", {
upper = 10.1
)

expect_equal(
expect_number(
mean(results@longitudinal[results@longitudinal$observed, ]$sld),
2.766,
tolerance = 0.001
lower = 2,
upper = 4
)
})

Expand All @@ -147,16 +147,16 @@ test_that("simulate works with lambda_censor", {
)

expect_equal(mean(results@survival$event), 0.6601, tolerance = 0.001)
expect_equal(mean(results@survival$time), 1.74296455, tolerance = 0.001)
expect_equal(
expect_number(mean(results@survival$time), lower = 1, upper = 3)
expect_number(
mean(results@survival$time[results@survival$event == 0]),
1.5901,
tolerance = 0.001
lower = 1,
upper = 2
)
expect_equal(
expect_number(
mean(results@survival$time[results@survival$event == 1]),
1.819548872,
tolerance = 0.001
lower = 1,
upper = 3
)

joined <- dplyr::left_join(
Expand All @@ -165,6 +165,6 @@ test_that("simulate works with lambda_censor", {
by = "id"
)

expect_true(all(!joined$observed[joined$time.y > joined$time.x]))
expect_true(!any(joined$observed[joined$time.y > joined$time.x]))
expect_true(all(joined$observed[joined$time.y <= joined$time.x]))
})
Loading