Skip to content

Hydropower Cascades/Streamflow Modeling#911

Open
erikbjornerem wants to merge 10 commits into
GenXProject:mainfrom
erikbjornerem:hydro_cascade
Open

Hydropower Cascades/Streamflow Modeling#911
erikbjornerem wants to merge 10 commits into
GenXProject:mainfrom
erikbjornerem:hydro_cascade

Conversation

@erikbjornerem
Copy link
Copy Markdown

Description

What type of PR is this? (check all applicable)

  • Feature
  • Bug Fix
  • Documentation Update
  • Code Refactor
  • Performance Improvements

Related Tickets & Documents

Checklist

  • [Kinda] Code changes are sufficiently documented; i.e. new functions contain docstrings and .md files under /docs/src have been updated if necessary.
  • [No] The latest changes on the target branch have been incorporated, so that any conflicts are taken care of before merging. This can be accomplished either by merging in the target branch (e.g. 'git merge develop') or by rebasing on top of the target branch (e.g. 'git rebase develop'). Please do not hesitate to reach out to the GenX development team if you need help with this.
  • [Kinda] Code has been tested to ensure all functionality works as intended.
  • [No ] CHANGELOG.md has been updated (if this is a 'notable' change).
  • [ Yes] I consent to the release of this PR's code under the GNU General Public license.

How this can be tested

Post-approval checklist for GenX core developers

After the PR is approved

  • Check that the latest changes on the target branch are incorporated, either via merge or rebase
  • Remember to squash and merge if incorporating into develop

…sources for easier debugging. Storage of water in Mm3 and conversions. Removed hydro operational reserves and created functions for writing hydro_cascade results. Some fixes of scaling water to power conversion factors
…reservoir link functions discharge_to and pump_to. Added spillage limits to avoid unwanted operation (spilling 60% reservoir in single hour). Updated example 12
…r balance constraint. Added generation from reversible pump turbines. Added ramping for pumps. Added 20% minimum reservoir level for hydro <-- This should be input and not hard-coded.
…commenting to hydro_cascade.jl and load_resources_data.jl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant