Only send callback command when needed#866
Merged
WouterGritter merged 2 commits intoMay 12, 2026
Merged
Conversation
…leCommandsPacket when needed (when one or more click callback has been registered through Adventure's API). Velocity does not register any click-callbacks itself; callbacks will only be registered if plugins make use of the feature (i.e. if no plugins use this feature, we never send this command to the player, this avoids clutter on command tabcompletion)
WouterGritter
force-pushed
the
only-send-callback-command-when-needed
branch
from
9d31eb3 to
2888bf1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branches off of #865 (should be merged first)
Only add/inject Velocity's velocity:callback command to the AvailableCommandsPacket when needed (when one or more click callback has been registered through Adventure's API). Velocity does not register any click-callbacks itself; callbacks will only be registered if plugins make use of the feature (i.e. if no plugins use this feature, we never send this command to the player, this avoids clutter on command tabcompletion).