Skip to content

Revert profile caching #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WouterGritter merged 3 commits into from
Mar 29, 2026
Merged

Revert profile caching #822

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d86888a
Revert profile caching
WouterGritter Mar 29, 2026
1695b3b
Re-use shared HttpClient to take advantage of connection pooling
WouterGritter Mar 29, 2026
fe73f56
Setup encryption before possible disconnect
WouterGritter Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
153 changes: 0 additions & 153 deletions proxy/src/main/java/com/velocityctd/proxy/connection/profile/GameProfileFetcher.java
View file
Open in desktop

This file was deleted.

70 changes: 0 additions & 70 deletions proxy/src/main/java/com/velocityctd/proxy/connection/profile/GameProfileResponse.java
View file
Open in desktop

This file was deleted.

28 changes: 0 additions & 28 deletions ...rc/main/java/com/velocityctd/proxy/connection/profile/cache/GameProfileCacheStrategy.java
View file
Open in desktop

This file was deleted.

46 changes: 0 additions & 46 deletions .../src/main/java/com/velocityctd/proxy/connection/profile/cache/MemoryGameProfileCache.java
View file
Open in desktop

This file was deleted.

51 changes: 0 additions & 51 deletions proxy/src/main/java/com/velocityctd/proxy/redis/profilecache/RedisGameProfileCache.java
View file
Open in desktop

This file was deleted.

12 changes: 0 additions & 12 deletions proxy/src/main/java/com/velocitypowered/proxy/VelocityServer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
import com.velocityctd.proxy.command.builtin.QueueAdminCommand;
import com.velocityctd.proxy.command.builtin.SlashServerCommand;
import com.velocityctd.proxy.command.builtin.TransferCommand;
import com.velocityctd.proxy.connection.profile.GameProfileFetcher;
import com.velocityctd.proxy.queue.RedisVelocityQueueManager;
import com.velocityctd.proxy.queue.VelocityQueueManager;
import com.velocityctd.proxy.redis.VelocityRedis;
Expand Down Expand Up @@ -333,11 +332,6 @@ public class VelocityServer implements ProxyServer, ForwardingAudience {
*/
private @MonotonicNonNull VelocityRedis redis;

/**
* The global {@link GameProfileFetcher} used by {@link com.velocitypowered.proxy.connection.client.InitialLoginSessionHandler}.
*/
private @MonotonicNonNull GameProfileFetcher gameProfileFetcher;

VelocityServer(final ProxyOptions options) {
pluginManager = new VelocityPluginManager(this);
eventManager = new VelocityEventManager(pluginManager);
Expand Down Expand Up @@ -384,10 +378,6 @@ public VelocityRedis getRedis() {
return redis;
}

public @MonotonicNonNull GameProfileFetcher getGameProfileFetcher() {
return gameProfileFetcher;
}

@Override
public final VelocityConfiguration getConfiguration() {
return this.configuration;
Expand Down Expand Up @@ -524,8 +514,6 @@ void start() {
}
}

gameProfileFetcher = new GameProfileFetcher(this);

if (configuration.getRedis().isEnabled()) {
redis = new VelocityRedis(this);
}
Expand Down
Loading