ci(link-check): exclude flaky aicpa-cima.com from lychee - #221
ci(link-check): exclude flaky aicpa-cima.com from lychee#221ethanolivertroy wants to merge 2 commits into
Conversation
The AICPA SOC overview link in the us-sox skill intermittently returns 502 Bad Gateway to lychee's client (bot protection) while returning 200 to curl and browsers. It was failing the link-check workflow on unrelated PRs, most recently #218. Same rationale as the existing ecfr.gov and canada.ca exclusions. Co-authored-by: Ethan Troy <ethanolivertroy@users.noreply.github.com>
|
Warning Review limit reached
Next review available in: 22 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. 📝 WalkthroughWalkthroughThe Lychee configuration excludes all ChangesLink validation
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThe PR prevents intermittent AICPA-CIMA bot-protection responses from failing unrelated link-check runs.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| lychee.toml | Adds a valid, narrowly host-boundary-matched exclusion for the flaky AICPA-CIMA domain without introducing a blocking failure. |
Reviews (2): Last reviewed commit: "ci(link-check): anchor aicpa-cima.com ex..." | Re-trigger Greptile
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@lychee.toml`:
- Around line 29-31: Update the aicpa-cima.com exclusion pattern in lychee.toml
to require a host boundary immediately after `.com`, allowing only the exact
domain or valid URL delimiter/end while preventing matches such as
`aicpa-cima.com.evil.example`.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
Without the boundary the pattern would also exclude lookalike hosts such as aicpa-cima.com.evil.example. Co-authored-by: Ethan Troy <ethanolivertroy@users.noreply.github.com>
2 participants
Summary
The AICPA SOC overview link in
plugins/frameworks/us-sox/skills/us-sox-expert/SKILL.mdintermittently returns502 Bad Gatewayto lychee's client (bot protection) while returning200 OKto curl and browsers. It was failing thelink-checkworkflow on unrelated PRs, most recently the lychee failure on #218. Addsaicpa-cima.comto thelychee.tomlexclusion list with the same rationale as the existingecfr.govandcanada.caentries.Verified the link is alive, so this is a flake exclusion, not a dead link being hidden:
Type of change
Schema impact
schemas/finding.schema.jsonchangedTest plan
Config-only change to
lychee.toml; thelink-checkworkflow on this PR exercises it directly (the workflow triggers onlychee.tomlchanges).CHANGELOG
Notes for reviewers
Domain-level exclusion rather than URL-level, so future AICPA references (likely for a SOC 2-focused repo) do not re-introduce the flake.
Summary by CodeRabbit
aicpa-cima.comfrom automated link checking due to intermittent validation failures.