Skip to content

fix: cycleway topic didn't ignore features that set value “no”#1018

Merged
joker234 merged 3 commits intomainfrom
improve-topic-cycleway
May 8, 2026
Merged

fix: cycleway topic didn't ignore features that set value “no”#1018
joker234 merged 3 commits intomainfrom
improve-topic-cycleway

Conversation

@joker234
Copy link
Copy Markdown
Member

@joker234 joker234 commented May 7, 2026

Description

The cycleway topic did include a lot of ways that are tagged with tag combinations like highway=residential and cycleway:both=no. This means it does not qualify as a cycleway. It just states that there isn't any cycle infrastructure. This PR proposes to change this behaviour and exclude all ways with just cycleway tags that equal to no.

To see the many ways this applies to and the extent of the error, one can have a look at this query. All shown ways are not covered by the fixed filter anymore (for Heidelberg): https://overpass-turbo.eu/s/2pma

image

Corresponding issue

None

New or changed dependencies

None

Checklist

  • I have ensured my branch is mergeable with main (e.g. through git rebase main if necessary)
  • My code follows the style guide and was checked with pre-commit before committing
  • I have commented my code
  • I have added sufficient unit and integration tests
  • I have added new Hurl regression tests and checked all existing tests
  • I have updated the CHANGELOG.md

@joker234 joker234 requested review from matthiasschaub and tyrasd May 7, 2026 18:18
@joker234 joker234 added bug Something isn't working topic labels May 7, 2026
@joker234 joker234 requested a review from SlowMo24 May 7, 2026 18:18
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 7, 2026

Copy link
Copy Markdown
Contributor

@SlowMo24 SlowMo24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is definitely an improvement

But as long as roads are not treated as the two-way object they are, I still feel we have not approached the scientific optimum. I.e. if a road has a bike lane on both sides it should not be counted the same as one that only has it one one side IMO. Yet, I acknowledge that that is difficult to fulfil in this context.

Comment thread ohsome_quality_api/topics/presets.yaml Outdated
Co-authored-by: Martin Raifer <martin@raifer.tech>
@joker234 joker234 merged commit a7eb73e into main May 8, 2026
1 check passed
@joker234 joker234 deleted the improve-topic-cycleway branch May 8, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working topic

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants