fix: cycleway topic didn't ignore features that set value “no”#1018
Merged
fix: cycleway topic didn't ignore features that set value “no”#1018
Conversation
|
SlowMo24
approved these changes
May 8, 2026
Contributor
SlowMo24
left a comment
There was a problem hiding this comment.
this is definitely an improvement
But as long as roads are not treated as the two-way object they are, I still feel we have not approached the scientific optimum. I.e. if a road has a bike lane on both sides it should not be counted the same as one that only has it one one side IMO. Yet, I acknowledge that that is difficult to fulfil in this context.
tyrasd
approved these changes
May 8, 2026
Co-authored-by: Martin Raifer <martin@raifer.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
The cycleway topic did include a lot of ways that are tagged with tag combinations like
highway=residentialandcycleway:both=no. This means it does not qualify as a cycleway. It just states that there isn't any cycle infrastructure. This PR proposes to change this behaviour and exclude all ways with just cycleway tags that equal tono.To see the many ways this applies to and the extent of the error, one can have a look at this query. All shown ways are not covered by the fixed filter anymore (for Heidelberg): https://overpass-turbo.eu/s/2pma
Corresponding issue
None
New or changed dependencies
None
Checklist
main(e.g. throughgit rebase mainif necessary)