Fix CI: safe lock scripts, remove tests/ from CS Fixer#27
Merged
Conversation
- Replace unsafe cat/herestring redirection with jq > .tmp && mv pattern to avoid truncating composer.json before jq reads it - Fix jq expression in lock-symfony-version.sh: use .key as $k to avoid indexing a string with .key after a pipe - Remove tests/ from .php-cs-fixer.dist.php (directory no longer exists) Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
- Use PHP attributes in FeatureContext (Behat 4 dropped docblock support) - Remove Behat 3.31 + Symfony 8.x combos (incompatible: Behat 3.31 requires symfony/config ^5.4||^6.4||^7.0) - Remove PHP 8.3 + Symfony 8.x combos (Symfony 8.0+ requires PHP >=8.4) - Add PHP 8.5 to stable (Behat 3.31 + Symfony 7.4) and all Behat 4 rows Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lock-symfony-version.shandlock-behat-version.sh: replaced thecat <<< $(jq ... < file) > filepattern (which could truncate the file before jq reads it) withjq ... < file > file.tmp && mv file.tmp file— safe and atomiclock-symfony-version.sh: the original expression used.keyafter piping the key through|, which causedCannot index string with string "key"— fixed by capturing.key as $kand using$kin bothtest()callstests/from.php-cs-fixer.dist.php: the directory no longer exists (tests are provided byfriends-of-behat/test-context)Fixes the broken build from the #26 merge: https://github.com/FriendsOfBehat/ServiceContainerExtension/actions/runs/27420597476
🤖 Generated with Claude Code