Implement always on default viewing mode#9341
Conversation
github-actions
Bot
added
the
PR: waiting for review
| External Player: External Player ({externalPlayerName}) | ||
| Full Window (Always On): Full Window (Always On) | ||
| Full Screen (Always On): Full Screen (Always On) | ||
| Tooltip: Most default viewing modes are only applied when switching to watch page (e.g. playing another video in a playlist won't be applied selected view mode again). Those modes with '(Always On)' are applied every time. |
There was a problem hiding this comment.
Maybe something like this?
| Tooltip: Most default viewing modes are only applied when switching to watch page (e.g. playing another video in a playlist won't be applied selected view mode again). Those modes with '(Always On)' are applied every time. | |
| Tooltip: Most default viewing modes are only applied at the start of each watch session. Changes made during the session persist until it ends. Always-on viewing modes remain active throughout the watch session. |
There was a problem hiding this comment.
Most default viewing modes are only applied at the start of each watch session. Changes made during the session persist until it ends. part looks ok
Always-on viewing modes remain active throughout the watch session. not so much coz "remain active" read strange (like you can't turn it off)
I think the text should explain that those modes makes full window/screen applied when switched to a new video regardless of whatever mode change made when viewing previous video and not sure how to make the text short :)
There was a problem hiding this comment.
What about this
Always-on viewing modes are applied whenever you switch to a new video, regardless of any viewing mode changes made during the previous video
There was a problem hiding this comment.
Looks good! What about the first part change i suggested, want to keep it like that or alter it?
There was a problem hiding this comment.
Forgot to change that too, updated
3 participants
Pull Request Type
Related issue
Closes #9326
Description
Add 2 more "default" viewing mode (I guess it's not "default" anymore but I don't know how to name it...
Screenshots
Testing
A. Existing modes
B. New modes
Desktop
Additional context
Text to be discussed/updated~