Skip to content

Add play all button #9340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
r3dArch wants to merge 3 commits into
base: development
Choose a base branch
from
+28 −0
Open

Add play all button #9340

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e4c6002
Added play all button to channel tabs
r3dArch Jun 28, 2026
062e789
Add margin for consistent spacing of button
r3dArch Jul 8, 2026
f9d3089
change play all to view all
r3dArch Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/renderer/views/Channel/Channel.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
display: flex;
flex-direction: row;
justify-content: flex-end;
align-items: baseline;
gap: 10px;
margin-block-end: 10px;
}

Expand Down
24 changes: 24 additions & 0 deletions src/renderer/views/Channel/Channel.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,11 @@
:related-channels="relatedChannels"
/>
<div class="select-container">
<FtButton
v-if="showPlayAllButton"
:label="$t('Channel.Play All')"
@click="router.push(currentTabPlayAllRoute)"
/>
<FtSelect
v-if="showVideoSortBy"
v-show="currentTab === 'videos' && (showFetchMoreButton || filteredVideos.length > 1)"
Expand Down Expand Up @@ -280,6 +285,7 @@ import FtElementList from '../../components/FtElementList/FtElementList.vue'
import FtFlexBox from '../../components/ft-flex-box/ft-flex-box.vue'
import FtLoader from '../../components/FtLoader/FtLoader.vue'
import FtSelect from '../../components/FtSelect/FtSelect.vue'
import FtButton from '../../components/FtButton/FtButton.vue'

import store from '../../store/index'

Expand Down Expand Up @@ -510,6 +516,24 @@ const tabInfoValues = computed(() => {
return values
})

const showPlayAllButton = computed(() => {
switch (currentTab.value) {
case 'videos': return (videoSortBy.value === 'newest' || videoSortBy.value === 'popular') && (showFetchMoreButton.value || filteredVideos.value.length > 1)
case 'shorts': return (shortSortBy.value === 'newest' || shortSortBy.value === 'popular') && (showFetchMoreButton.value || filteredShorts.value.length > 1)
case 'live': return (liveSortBy.value === 'newest' || liveSortBy.value === 'popular') && (showFetchMoreButton.value || filteredLive.value.length > 1)
default: return false
}
})

const currentTabPlayAllRoute = computed(() => {
switch (currentTab.value) {
case 'videos': return `/playlist/${getChannelPlaylistId(id.value, 'videos', videoSortBy.value)}`
case 'shorts': return `/playlist/${getChannelPlaylistId(id.value, 'shorts', shortSortBy.value)}`
case 'live': return `/playlist/${getChannelPlaylistId(id.value, 'live', liveSortBy.value)}`
default: return ''
}
})

watch(route, () => {
if (skipRouteChangeWatcherOnce) {
skipRouteChangeWatcherOnce = false
Expand Down
1 change: 1 addition & 0 deletions static/locales/en-US.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -775,6 +775,7 @@ Channel:
This channel does not allow searching: This channel does not allow searching
This channel is age-restricted and currently cannot be viewed in FreeTube.: This channel is age-restricted and currently cannot be viewed in FreeTube.
Channel Tabs: Channel Tabs
Play All: Play All

@PikachuEXE PikachuEXE Jul 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering if we should label the button as Play All or View All coz when I press it I view the playlist not starts playing it
Not blocking

@r3dArch r3dArch Jul 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe Open Playlist? I think the context would imply that it opens a playlist of the current channel tab.

@PikachuEXE PikachuEXE Jul 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Problem is when user (or just me) sees Open Playlist on a tab he would be confused first on why "playlist" is relevant here
View all means view all entries (videos/lives/shorts) and whether it's in playlist form or what is something else but the desired effect is "view all" not "open playlist" (that's implementation)

@r3dArch r3dArch Jul 9, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good now. Thank you for the feedback.

Videos:
Videos: Videos
This channel does not currently have any videos: This channel does not currently
Expand Down