Modified to compile against spdlog-1.15.2 and mbedtls-3.6.3 #422
Open
vsimkus-agbr wants to merge 2 commits into
Open
Modified to compile against spdlog-1.15.2 and mbedtls-3.6.3 #422vsimkus-agbr wants to merge 2 commits into
vsimkus-agbr wants to merge 2 commits into
Conversation
…rsion 11.5.0 20240719 (Red Hat 11.5.0-5) (GCC)
|
您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。
|
| } | ||
|
|
||
| ret = mbedtls_rsa_pkcs1_encrypt( rsa, mbedtls_ctr_drbg_random, &ctr_drbg, MBEDTLS_RSA_PUBLIC, input.size(), (const unsigned char*)input.data(), buff ); | ||
| ret = mbedtls_rsa_pkcs1_encrypt( rsa, mbedtls_ctr_drbg_random, &ctr_drbg,input.size(), (const unsigned char*)input.data(), buff ); |
There was a problem hiding this comment.
While trying to compile on Ubuntu 24.04 for a ROS2 project, this line was an issue. I had to revert this change. Otherwise I can confirm that the changes made solved the compilation issues I was having because of spdlog.
Information on my setup:
- Ubuntu 24.04
- CMake version 3.28.3
- g++ 13.3.0
- libmbedtls-dev 2.28.8-1
- libspdlog-dev 1.12.0
|
您好，我最近正在休假中，无法亲自回复您的邮件。我将在假期结束后，尽快给您回复。
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to compile with newer versions of spdlog and mbedtls. Tested with GCC 11.5.0 on Red Hat Enterprise Linux release 9.5