Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -76,3 +76,9 @@ client_secret.json
/app/mailsync.exe
/app/mailsync.dSYM
.idea

# Debug symbol files
**/*.pdb

# Claude Code local settings
.claude/settings.local.json
191 changes: 169 additions & 22 deletions app/internal_packages/account-sidebar/lib/sidebar-section.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,14 @@
* Full docs: https://github.com/decaffeinate/decaffeinate/blob/master/docs/suggestions.md
*/
import _ from 'underscore';
import React from 'react';
import {
Actions,
Account,
SyncbackCategoryTask,
CategoryStore,
AccountGroupStore,
AccountGroup,
Label,
ExtensionRegistry,
RegExpUtils,
Expand Down Expand Up @@ -83,6 +86,120 @@ class SidebarSection {
};
}

static _nameStyleForGroup(group: AccountGroup): React.CSSProperties | undefined {
const style: React.CSSProperties = {};
if (group.color) {
style.color = group.color;
}
const ds = group.displayStyle || 'normal';
if (ds === 'bold' || ds === 'bold-italic') {
style.fontWeight = 700;
}
if (ds === 'italic' || ds === 'bold-italic') {
style.fontStyle = 'italic';
}
if (Object.keys(style).length === 0) return undefined;
return style;
}

static _buildGroupedCategoryChildren(
accounts: Account[],
names: string[],
groups: AccountGroup[]
): ISidebarItem[] {
const children: ISidebarItem[] = [];
const groupedAccountIds = new Set<string>();

for (const group of groups) {
const groupAccounts = accounts.filter(acc => group.accountIds.includes(acc.id));
if (groupAccounts.length === 0) continue;

groupAccounts.forEach(acc => groupedAccountIds.add(acc.id));

const groupCats = _.compact(
groupAccounts.map(acc =>
_.first(_.compact(names.map(name => CategoryStore.getCategoryByRole(acc, name))))
)
);
if (groupCats.length === 0) continue;

const groupChildren = groupAccounts
.map(acc => {
const cat = _.first(
_.compact(names.map(name => CategoryStore.getCategoryByRole(acc, name)))
);
if (!cat) return null;
return SidebarItem.forCategories([cat], {
name: acc.label,
editable: false,
deletable: false,
});
})
.filter(Boolean);

children.push(
SidebarItem.forCategories(groupCats, {
name: group.name,
children: groupChildren,
editable: false,
deletable: false,
nameStyle: this._nameStyleForGroup(group),
})
);
}

// Add ungrouped accounts as individual children
accounts.forEach(acc => {
if (groupedAccountIds.has(acc.id)) return;
const cat = _.first(
_.compact(names.map(name => CategoryStore.getCategoryByRole(acc, name)))
);
if (!cat) return;
children.push(
SidebarItem.forCategories([cat], { name: acc.label, editable: false, deletable: false })
);
});

return children;
}

static _buildGroupedPseudoChildren(
accounts: Account[],
groups: AccountGroup[],
itemFactory: (accountIds: string[], opts?: Partial<ISidebarItem>) => ISidebarItem
): ISidebarItem[] {
const children: ISidebarItem[] = [];
const groupedAccountIds = new Set<string>();

for (const group of groups) {
const groupAccounts = accounts.filter(acc => group.accountIds.includes(acc.id));
if (groupAccounts.length === 0) continue;

groupAccounts.forEach(acc => groupedAccountIds.add(acc.id));

const groupIds = groupAccounts.map(acc => acc.id);
const groupChildren = groupAccounts.map(acc =>
itemFactory([acc.id], { name: acc.label })
);

children.push(
itemFactory(groupIds, {
name: group.name,
children: groupChildren,
nameStyle: this._nameStyleForGroup(group),
})
);
}

// Add ungrouped accounts as individual children
accounts.forEach(acc => {
if (groupedAccountIds.has(acc.id)) return;
children.push(itemFactory([acc.id], { name: acc.label }));
});

return children;
}

static standardSectionForAccounts(accounts?: Account[]): ISidebarSection {
let children;
if (!accounts || accounts.length === 0) {
Expand All @@ -95,6 +212,9 @@ class SidebarSection {
return this.standardSectionForAccount(accounts[0]);
}

const groups = AccountGroupStore.groups();
const hasGroups = groups.length > 0;

const standardNames = ['inbox', 'important', 'sent', ['archive', 'all'], 'spam', 'trash'];
const items = [];

Expand All @@ -105,19 +225,23 @@ class SidebarSection {
continue;
}

children = [];
// eslint-disable-next-line
accounts.forEach(acc => {
const cat = _.first(
_.compact((names as string[]).map(name => CategoryStore.getCategoryByRole(acc, name)))
);
if (!cat) {
return;
}
children.push(
SidebarItem.forCategories([cat], { name: acc.label, editable: false, deletable: false })
);
});
if (hasGroups) {
children = this._buildGroupedCategoryChildren(accounts, names, groups);
} else {
children = [];
// eslint-disable-next-line
accounts.forEach(acc => {
const cat = _.first(
_.compact((names as string[]).map(name => CategoryStore.getCategoryByRole(acc, name)))
);
if (!cat) {
return;
}
children.push(
SidebarItem.forCategories([cat], { name: acc.label, editable: false, deletable: false })
);
});
}

items.push(
SidebarItem.forCategories(categories, { children, editable: false, deletable: false })
Expand All @@ -126,15 +250,38 @@ class SidebarSection {

const accountIds = _.pluck(accounts, 'id');

const starredItem = SidebarItem.forStarred(accountIds, {
children: accounts.map(acc => SidebarItem.forStarred([acc.id], { name: acc.label })),
});
const unreadItem = SidebarItem.forUnread(accountIds, {
children: accounts.map(acc => SidebarItem.forUnread([acc.id], { name: acc.label })),
});
const draftsItem = SidebarItem.forDrafts(accountIds, {
children: accounts.map(acc => SidebarItem.forDrafts([acc.id], { name: acc.label })),
});
let starredChildren, unreadChildren, draftsChildren;
if (hasGroups) {
starredChildren = this._buildGroupedPseudoChildren(
accounts,
groups,
SidebarItem.forStarred.bind(SidebarItem)
);
unreadChildren = this._buildGroupedPseudoChildren(
accounts,
groups,
SidebarItem.forUnread.bind(SidebarItem)
);
draftsChildren = this._buildGroupedPseudoChildren(
accounts,
groups,
SidebarItem.forDrafts.bind(SidebarItem)
);
} else {
starredChildren = accounts.map(acc =>
SidebarItem.forStarred([acc.id], { name: acc.label })
);
unreadChildren = accounts.map(acc =>
SidebarItem.forUnread([acc.id], { name: acc.label })
);
draftsChildren = accounts.map(acc =>
SidebarItem.forDrafts([acc.id], { name: acc.label })
);
}

const starredItem = SidebarItem.forStarred(accountIds, { children: starredChildren });
const unreadItem = SidebarItem.forUnread(accountIds, { children: unreadChildren });
const draftsItem = SidebarItem.forDrafts(accountIds, { children: draftsChildren });

// Order correctly: Inbox, Unread, Starred, rest... , Drafts
items.splice(1, 0, unreadItem, starredItem);
Expand Down
2 changes: 2 additions & 0 deletions app/internal_packages/account-sidebar/lib/sidebar-store.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import {
Actions,
Account,
AccountStore,
AccountGroupStore,
ThreadCountsStore,
WorkspaceStore,
OutboxStore,
Expand Down Expand Up @@ -64,6 +65,7 @@ class SidebarStore extends MailspringStore {
this.listenTo(Actions.setCollapsedSidebarItem, this._onSetCollapsedByName);
this.listenTo(SidebarActions.setKeyCollapsed, this._onSetCollapsedByKey);
this.listenTo(AccountStore, this._onAccountsChanged);
this.listenTo(AccountGroupStore, this._updateSections);
this.listenTo(FocusedPerspectiveStore, this._onFocusedPerspectiveChanged);
this.listenTo(WorkspaceStore, this._updateSections);
this.listenTo(OutboxStore, this._updateSections);
Expand Down
2 changes: 2 additions & 0 deletions app/internal_packages/account-sidebar/lib/types.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import React from 'react';
import { MailboxPerspective } from 'mailspring-exports';

export interface ISidebarItem {
Expand All @@ -11,6 +12,7 @@ export interface ISidebarItem {
selected: boolean;
collapsed: boolean;
counterStyle: string;
nameStyle?: React.CSSProperties;
onDelete?: () => void;
onEdited?: (item, name: string) => void;
onCollapseToggled: () => void;
Expand Down
8 changes: 8 additions & 0 deletions app/internal_packages/preferences/lib/main.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,14 @@ export function activate() {
order: 2,
})
);
PreferencesUIStore.registerPreferencesTab(
new PreferencesUIStore.TabItem({
tabId: 'Account Groups',
displayName: localized('Account Groups'),
componentClassFn: () => require('./tabs/preferences-account-groups').default,
order: 2.5,
})
);
PreferencesUIStore.registerPreferencesTab(
new PreferencesUIStore.TabItem({
tabId: 'Subscription',
Expand Down
Loading