Add robot has_ball feedback#118
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds real-robot has_ball feedback parsing and a small Tk-based teleop GUI for manual testing, enabling RobotInfoRefiner to populate robot.has_ball from real robot feedback.
Changes:
- Implemented
RealRobotController.get_robots_responses()to parse serial feedback packets and emitRobotResponse(has_ball=...). - Removed the previous “read_all/placeholder” feedback handling in
send_robot_commands(). - Added a new
telop_gui.pyTkinter teleop utility that displayshas_ballstatus per robot.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
utama_core/team_controller/src/controllers/real/real_robot_controller.py |
Adds serial feedback parsing to produce RobotResponse with has_ball. |
utama_core/team_controller/src/controllers/real/telop_gui.py |
New Tk GUI for driving robots and visualizing has_ball feedback. |
energy-in-joles
approved these changes
May 8, 2026
Comment on lines
+76
to
+83
| while True: | ||
| # 2. Look for header | ||
| if len(self._buffer) < 1: | ||
| break | ||
|
|
||
| if self._buffer[0] != HEADER: | ||
| self._buffer.pop(0) | ||
| continue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement
has_ballfeedback for the robot.I only noticed #106 after making this, that is probably the better PR in the long run, although I'm about to go make some comments on it.
Added
telop_gui.pyas it's very useful for testing, if it's in the wrong place, or shouldn't be here at all, let me know and I'll move/remove it.