Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #865 +/- ##
=======================================
Coverage 94.25% 94.25%
=======================================
Files 40 40
Lines 6757 6757
=======================================
Hits 6369 6369
Misses 388 388 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4 tasks
Merged
Member
|
Since typos seem to sneak in regularly I would say lets add this to the CI to catch typos early on. |
termi-official
requested changes
Mar 9, 2026
Co-authored-by: Dennis Ogiermann <termi-official@users.noreply.github.com>
Co-authored-by: Dennis Ogiermann <termi-official@users.noreply.github.com>
termi-official
approved these changes
Mar 10, 2026
Member
termi-official
left a comment
There was a problem hiding this comment.
I think the .typos.toml is sufficiently easy to find (and remember) that we do not need any additional documentation for that.
Member
Author
|
If this gets too annoying then it can easily be removed, but this should reduce review work a bit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It does find a few mistakes around, see https://github.com/Ferrite-FEM/Ferrite.jl/actions/runs/7427267344/job/20212641841 (Edit: fixed in #866)
But seems somewhat fragile as I had to add quite some exceptions.
On the other hand, since it should only run on pull requests it won't indicate CI failure even if not fixed.