avoid creating unnecessary views in InterfaceValues#1306
Merged
KristofferC merged 1 commit intomasterfrom Mar 18, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1306 +/- ##
==========================================
- Coverage 94.25% 91.82% -2.44%
==========================================
Files 40 40
Lines 6757 6946 +189
==========================================
+ Hits 6369 6378 +9
- Misses 388 568 +180 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fredrikekre
approved these changes
Mar 17, 2026
KristofferC
force-pushed
the
kc/view_function_gradent
branch
2 times, most recently
from
2d9757e to
7dad69c
Compare
KristofferC
force-pushed
the
kc/view_function_gradent
branch
from
7dad69c to
4b13ae7
Compare
KnutAM
reviewed
Mar 18, 2026
Comment on lines
229
to
+230
| # TODO: Deprecate this, nobody is using this in practice... | ||
| function function_gradient(fe_v::AbstractValues, q_point::Int, u::AbstractVector{<:Vec}) | ||
| function function_gradient(fe_v::AbstractValues, q_point::Int, u::AbstractVector{<:Vec}, dof_range = eachindex(u)) |
Member
There was a problem hiding this comment.
What path made this active, @KristofferC?
Do we use this somewhere currently, or was it just in a test?
Collaborator
Author
There was a problem hiding this comment.
The calls where I changed the view to instead pass the dofs should dispatch to here, but if this argument was not present, it dispatched to the function above (the one not specialized for <:Vec).
This was to fix a test failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1301