Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1037 +/- ##
=======================================
Coverage 94.19% 94.19%
=======================================
Files 40 40
Lines 6661 6662 +1
=======================================
+ Hits 6274 6275 +1
Misses 387 387 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
KnutAM
added
the
awaiting review
Member
Author
|
Any objections to introducing |
Member
I like it. |
KnutAM
removed
the
awaiting review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solve #1033
Introduces
Ferrite.asset_urlwhich allows us to have one place to define the url for assets, and makes it easy to download assets for use in tutorials. Coming back to this after some time, I believe that this addition is alright. Although it doesn't really belong in Ferrite, it makes it possible to download meshes for the tutorials without too much extra code while being easily runnable.