fix: actually check wineserver#397
Merged
thw26 merged 1 commit intoFaithLife-Community:mainfrom Apr 10, 2025
Merged
Conversation
function failed to return anything, causing it to return None which is falsy. Regressed since 7b8b1cb causing FaithLife-Community#396 Fixes: FaithLife-Community#396
thw26
approved these changes
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
function failed to return anything, causing it to return None which is falsy.
Regressed since 7b8b1cb causing #396
Also fixed typo in command string generation, as exe can be None
Tested:
Fixes: #396