Support Vineflower 1.12#123
Open
modmuss50 wants to merge 13 commits into
Open
Conversation
Co-authored-by: Copilot <copilot@github.com>
There was a problem hiding this comment.
Pull request overview
This PR adds support for Vineflower 1.12.0 by introducing versioned Vineflower runtimes, wiring the selected runtime version through permalinks, and isolating cached decompile results by Vineflower version. It also adds UI/test coverage to signal when a legacy (/1/) permalink is using an older decompiler.
Changes:
- Added multi-version Vineflower runtime loading (1.11.2 + 1.12.0) and mapped permalink prefixes (/1/, /2/) to Vineflower versions.
- Updated decompiler worker/client to version decompile cache entries (Dexie schema bump + version included in
DecompileResult). - Added UI warning + Playwright/Vitest tests for legacy permalinks and updated default permalink generation to /2/.
Reviewed changes
Copilot reviewed 17 out of 19 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/permalink.spec.ts | Adds e2e coverage for /1/ (legacy) vs /2/ permalinks, including runtime/log expectations. |
| src/workers/decompile/worker.ts | Versions Dexie cache keys by Vineflower version; routes decompile calls through version-aware Vineflower wrapper. |
| src/workers/decompile/types.ts | Extends DecompileResult to include the Vineflower version. |
| src/workers/decompile/client.ts | Propagates Vineflower version into worker runtime loading and decompile operations. |
| src/ui/JarDecompilerModal.tsx | Ensures whole-jar decompile uses the default (latest) Vineflower version. |
| src/ui/FilepathHeader.tsx | Adds a header slot for legacy decompiler warning UI. |
| src/ui/FileList.tsx | Updates “copy link” permalink prefix to reflect the latest Vineflower permalink version. |
| src/ui/DecompilerVersionWarning.tsx | New component that displays a “legacy decompiler” warning for old permalinks. |
| src/types/vf-runtime.d.ts | Updates module declarations for version-aliased Vineflower packages/runtimes. |
| src/logic/vineflower/vineflower.ts | New version-dispatch wrapper for loading runtime + decompile API across VF versions. |
| src/logic/vineflower/vf-1.12.0.ts | New implementation module to load and run Vineflower 1.12.0 (WASM/JS fallback). |
| src/logic/vineflower/vf-1.11.2.ts | Reworks existing VF 1.11.2 loader to use the new npm alias module paths. |
| src/logic/vineflower/versions.ts | Introduces Version type, default version, and permalink↔VF mapping helpers. |
| src/logic/State.ts | Adds vineflowerVersion state sourced from permalink version; resets to latest on file navigation. |
| src/logic/Permalink.ts | Emits permalinks using the mapped /{vfPermalinkVersion}/ prefix; default now uses /2/. |
| src/logic/Permalink.test.ts | Adds unit tests for parsing /2/ permalinks and diff permalinks. |
| src/logic/Decompiler.ts | Passes current vineflowerVersion through to class decompilation. |
| package.json | Replaces single @run-slicer/vf dependency with versioned npm aliases vf-1.11.2 and vf-1.12.0. |
| package-lock.json | Locks new alias dependencies and removes the direct @run-slicer/vf entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.