Bugfix: Refactor constructGraph() parameter to const shared ptr#1363
Merged
Bugfix: Refactor constructGraph() parameter to const shared ptr#1363
Conversation
Accessing the mutable graph here flags the graph as requiring a rebuild each step, greatly increasing the expense of visualising large graphs.
Robadob
changed the title
ptheywood
approved these changes
Mar 2, 2026
Member
Author
|
I've not fully diagnosed the cause, but I've attempted and failed to reproduce the bug so I'm fairly confident that it's not possible to trigger via host functions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accessing the mutable graph here flags the graph as requiring a rebuild each step, greatly increasing the expense of visualising large graphs.
Still chasing a different issue, this rebuild was changing what's stored in the src_dest map. It would appear if src_dest is flagged as updated after initial graph construction, src_dest map fails to be re-translated to index or similar.