Skip to content

[gui] Fix report filter expansion panel open state handling #4857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gulyasgergely902 wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −6
Open

[gui] Fix report filter expansion panel open state handling #4857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions web/server/vue-cli/src/components/Report/ReportFilter/Filters/Layout/FilterToolbar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<template>
<v-expansion-panels
v-model="value"
v-model="panelOpen"
>
<v-expansion-panel
eager
Expand Down Expand Up @@ -53,15 +53,15 @@ import { ref, watch } from "vue";

const props = defineProps({
title: { type: String, required: true },
panel: { type: Boolean, default: false }
panelActive: { type: Boolean, default: false }
});

const emit = defineEmits([ "clear" ]);

const value = ref(null);
const panelOpen = ref(undefined);

watch(() => props.panel, newPanel => {
value.value = newPanel ? 0 : null;
watch(() => props.panelActive, active => {
panelOpen.value = active ? 0 : undefined;
}, { immediate: true });
</script>

Expand Down
2 changes: 1 addition & 1 deletion web/server/vue-cli/src/components/Report/ReportFilter/Filters/SelectOption/SelectOption.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<template>
<FilterToolbar
:title="title"
:panel="panel"
:panel-active="panel"
@clear="emit('clear')"
>
<template v-slot:append-toolbar-title>
Expand Down
Loading