WIP: Overlay for Enzyme.jacobian#2839
Draft
vimarsh6739 wants to merge 2 commits intomainfrom
Draft
Conversation
vimarsh6739
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+840
to
+843
| x isa Annotation && | ||
| error( | ||
| "Reactant jacobian overlay v1 expects raw values or Const-wrapped values for non-differentiated arguments.", | ||
| ) |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| x isa Annotation && | |
| error( | |
| "Reactant jacobian overlay v1 expects raw values or Const-wrapped values for non-differentiated arguments.", | |
| ) | |
| x isa Annotation && error( | |
| "Reactant jacobian overlay v1 expects raw values or Const-wrapped values for non-differentiated arguments.", | |
| ) |
Comment on lines
+859
to
+862
| idx == 0 && | ||
| error( | ||
| "Reactant jacobian overlay v1 requires exactly one differentiable argument; all arguments were Const.", | ||
| ) |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| idx == 0 && | |
| error( | |
| "Reactant jacobian overlay v1 requires exactly one differentiable argument; all arguments were Const.", | |
| ) | |
| idx == 0 && error( | |
| "Reactant jacobian overlay v1 requires exactly one differentiable argument; all arguments were Const.", | |
| ) |
|
|
||
| function _jacobian_parse_chunk(chunk) | ||
| chunk === nothing && return nothing | ||
| chunk isa Val || error("Reactant jacobian overlay v1 expects `chunk` to be `nothing` or `Val{N}()`.") |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| chunk isa Val || error("Reactant jacobian overlay v1 expects `chunk` to be `nothing` or `Val{N}()`.") | |
| chunk isa Val || | |
| error("Reactant jacobian overlay v1 expects `chunk` to be `nothing` or `Val{N}()`.") |
Comment on lines
+877
to
+879
| error( | ||
| "Reactant jacobian overlay v1 requires explicit `n_outs` in reverse mode.", | ||
| ) |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| error( | |
| "Reactant jacobian overlay v1 requires explicit `n_outs` in reverse mode.", | |
| ) | |
| error("Reactant jacobian overlay v1 requires explicit `n_outs` in reverse mode.") |
Comment on lines
+886
to
+887
| (d isa Integer && d >= 0) || | ||
| error("Reactant jacobian overlay v1 requires non-negative integer `n_outs` dimensions.") |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| (d isa Integer && d >= 0) || | |
| error("Reactant jacobian overlay v1 requires non-negative integer `n_outs` dimensions.") | |
| (d isa Integer && d >= 0) || error( | |
| "Reactant jacobian overlay v1 requires non-negative integer `n_outs` dimensions.", | |
| ) |
Comment on lines
+946
to
+953
| isempty(kwargs) || | ||
| error( | ||
| "Reactant jacobian overlay v1 only supports `chunk` and `shadows` keywords in forward mode.", | ||
| ) | ||
| shadows === nothing || | ||
| error( | ||
| "Reactant jacobian overlay v1 does not support explicit `shadows`; omit the keyword to use internal Jacobian seeds.", | ||
| ) |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| isempty(kwargs) || | |
| error( | |
| "Reactant jacobian overlay v1 only supports `chunk` and `shadows` keywords in forward mode.", | |
| ) | |
| shadows === nothing || | |
| error( | |
| "Reactant jacobian overlay v1 does not support explicit `shadows`; omit the keyword to use internal Jacobian seeds.", | |
| ) | |
| isempty(kwargs) || error( | |
| "Reactant jacobian overlay v1 only supports `chunk` and `shadows` keywords in forward mode.", | |
| ) | |
| shadows === nothing || error( | |
| "Reactant jacobian overlay v1 does not support explicit `shadows`; omit the keyword to use internal Jacobian seeds.", | |
| ) |
Comment on lines
+1021
to
+1024
| n_out_elems == 1 || | ||
| error( | ||
| "Reactant jacobian overlay v1 currently supports only scalar-output functions in reverse mode (`prod(n_outs) == 1`).", | ||
| ) |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| n_out_elems == 1 || | |
| error( | |
| "Reactant jacobian overlay v1 currently supports only scalar-output functions in reverse mode (`prod(n_outs) == 1`).", | |
| ) | |
| n_out_elems == 1 || error( | |
| "Reactant jacobian overlay v1 currently supports only scalar-output functions in reverse mode (`prod(n_outs) == 1`).", | |
| ) |
Comment on lines
+1027
to
+1030
| (c === nothing || c == 1) || | ||
| error( | ||
| "Reactant jacobian overlay v1 reverse mode currently supports only `chunk=nothing` or `chunk=Val(1)`.", | ||
| ) |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| (c === nothing || c == 1) || | |
| error( | |
| "Reactant jacobian overlay v1 reverse mode currently supports only `chunk=nothing` or `chunk=Val(1)`.", | |
| ) | |
| (c === nothing || c == 1) || error( | |
| "Reactant jacobian overlay v1 reverse mode currently supports only `chunk=nothing` or `chunk=Val(1)`.", | |
| ) |
Comment on lines
+1043
to
+1046
| active_val isa Union{AbstractArray,AbstractFloat} || | ||
| error( | ||
| "Reactant jacobian overlay v1 currently supports differentiating only `AbstractArray` or `AbstractFloat` arguments.", | ||
| ) |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| active_val isa Union{AbstractArray,AbstractFloat} || | |
| error( | |
| "Reactant jacobian overlay v1 currently supports differentiating only `AbstractArray` or `AbstractFloat` arguments.", | |
| ) | |
| active_val isa Union{AbstractArray,AbstractFloat} || error( | |
| "Reactant jacobian overlay v1 currently supports differentiating only `AbstractArray` or `AbstractFloat` arguments.", | |
| ) |
Comment on lines
+125
to
+126
| jacobian_forward_with_shadows(x) = | ||
| Enzyme.jacobian(Forward, jacobian_loss, x; shadows=(nothing,)) |
Contributor
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| jacobian_forward_with_shadows(x) = | |
| Enzyme.jacobian(Forward, jacobian_loss, x; shadows=(nothing,)) | |
| function jacobian_forward_with_shadows(x) | |
| return Enzyme.jacobian(Forward, jacobian_loss, x; shadows=(nothing,)) | |
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.