Skip to content

Format Profiler.jl #2724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pangoraw merged 1 commit into from
Mar 24, 2026
+10 −7
Merged

Format Profiler.jl #2724

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions src/Profiler.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,14 +131,14 @@ function with_profiler(
params_content = read(nvidia_params, String)
if contains(params_content, "RmProfilingAdminOnly: 1")
@warn "CUPTI PM counter collection requires profiling permissions. " *
"Set NVreg_RestrictProfilingToAdminUsers=0 in " *
"/etc/modprobe.d/nvidia-profiler.conf and reload the nvidia module. " *
"Continuing without PM counters."
"Set NVreg_RestrictProfilingToAdminUsers=0 in " *
"/etc/modprobe.d/nvidia-profiler.conf and reload the nvidia module. " *
"Continuing without PM counters."
pm_counters = nothing
end
elseif !Sys.islinux()
@warn "PM counter collection is only supported on Linux with NVIDIA GPUs. " *
"Continuing without PM counters."
"Continuing without PM counters."
pm_counters = nothing
end
if pm_counters !== nothing
Expand All @@ -149,10 +149,13 @@ function with_profiler(
config_keys = collect(keys(config))
config_values = collect(values(config))
profiler = GC.@preserve config_keys config_values begin
key_ptrs = isempty(config_keys) ? C_NULL : Base.unsafe_convert.(Cstring, config_keys)
val_ptrs = isempty(config_values) ? C_NULL : Base.unsafe_convert.(Cstring, config_values)
key_ptrs =
isempty(config_keys) ? C_NULL : Base.unsafe_convert.(Cstring, config_keys)
val_ptrs =
isempty(config_values) ? C_NULL : Base.unsafe_convert.(Cstring, config_values)
Reactant.MLIR.API.CreateProfilerSession(
device_tracer_level, host_tracer_level,
device_tracer_level,
host_tracer_level,
isempty(config_keys) ? C_NULL : key_ptrs,
isempty(config_values) ? C_NULL : val_ptrs,
Cint(length(config_keys)),
Expand Down
Loading