Skip to content

add option to modify gpio base path for testing purposes #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sa-linetco wants to merge 5 commits into
base: master
Choose a base branch
from
Open

add option to modify gpio base path for testing purposes #40

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1043659
add possibility to inject gpio base path for testing purposes
sa-linetco Jun 21, 2018
ffa0b88
Merge branch 'master' into master
EnotionZ Jul 12, 2018
024eed4
call the ready callback only after the initial gpio value was read
sa-linetco Jun 26, 2018
b76dd14
fix syntax error
sa-linetco Jul 24, 2018
ae397c6
replace deprecated and wrong usage of fs.exists with fs.existsSync
sa-linetco Jul 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions lib/gpio.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
var fs = require('fs');
var util = require('util');
var path = require('path');
var EventEmitter = require('events').EventEmitter;
var exists = fs.exists || path.exists;
const fs = require('fs');
const util = require('util');
const path = require('path');
const EventEmitter = require('events').EventEmitter;

var defaultGpioBasePath = '/sys/class/gpio/';
const defaultGpioBasePath = '/sys/class/gpio/';

var logError = function (e) {
function logError(e) {

@rzr rzr Jul 25, 2018

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one is fine,

if (e) console.log(e.code, e.action, e.path);
};
var logMessage = function () {
}

function logMessage() {
if (exports.logging) console.log.apply(console, arguments);
};
}

var _write = function (str, file, fn, override) {
if (typeof fn !== "function") fn = logError;
Expand Down Expand Up @@ -45,7 +45,7 @@ var _unexport = function (_gpioBasePath, number, fn) {
}, 1);
};
var _export = function (_gpioBasePath, n, fn) {
if (exists(path.join(_gpioBasePath, 'gpio' + n))) {
if (fs.existsSync(path.join(_gpioBasePath, 'gpio' + n))) {
// already exported, unexport and export again
logMessage('Header already exported');
_unexport(_gpioBasePath, n, function () {
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "gpio",
"version": "0.3.1",
"version": "0.4.0",
"author": {
"name": "Sebastian Alkemade",

@rzr rzr Jul 25, 2018

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to change author ? here

"email": "sa@linetco.com"
Expand Down