Add RGBA support seperate from RGB support, this allows ignoring rgba…#30
Open
nathanbatson wants to merge 2 commits intoEdMSL:masterfrom
Open
Add RGBA support seperate from RGB support, this allows ignoring rgba…#30nathanbatson wants to merge 2 commits intoEdMSL:masterfrom
nathanbatson wants to merge 2 commits intoEdMSL:masterfrom
Conversation
… while still converting all other models to HEX
q2-kkendall
approved these changes
Feb 19, 2026
Co-authored-by: q2-kkendall <ken.kendall@q2.com>
wayneng55
approved these changes
Feb 19, 2026
Owner
|
Hi. Thanks for your contribution. I think I can merge it. But it is a good idea to add this functionality to also ignore hsla colors. I'll implement it later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this package is exactly what I need for some of the work I was doing. Our project needed to make the distinction between RGB and RGBA. We use RGBA to define transparent colors and only hex to define opaque colors.
I forked this to get across a hurtle initially, but realized this could be a good addition if that's something you'd like to pull in. I tried to copy the patterns already in the repo and only extended what I needed and re-used much of the RGB flow as possible.