Fix scanning issues#7623
Open
javiereguiluz wants to merge 1 commit into
Open
Conversation
javiereguiluz
force-pushed
the
fix_scanning_issues
branch
from
eb5ae00 to
b8d5dd1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes three client-side security issues flagged by GitHub code scanning:
1. Unvalidated URLs used for navigation/fetch (
app.js) — the filter button (data-href) and action links (data-ea-action-url) read a URL from the DOM and used it (href/window.location/fetch) without validation, allowing ajavascript:scheme to execute. A newsanitizeUrl()helper now restricts these to safe schemes. The filter URL — whose fetch response is injected viainnerHTML— is additionally required to be same-origin, so it can never load attacker-controlled remote HTML.2. Uploaded file name rendered as HTML (
field-file-upload.js) — the user-controlled file name was written viainnerHTML, so a file named e.g.<img src=x onerror=…>could run script. Switched totextContent.3. Fragile slug confirm-text decoding (
field-slug.js) — the lock-button confirmation message ran through areplace/JSON.parse/decodeURIComponentchain that didn't escape backslashes (CodeQL: incomplete string escaping). The attribute is already a plain, escaped string, so it's now passed directly toconfirm().