CCPPize prescribed_volcanic_aerosol (prescribed_volcaero); update tracer_data_test snapshot#477
CCPPize prescribed_volcanic_aerosol (prescribed_volcaero); update tracer_data_test snapshot#477jimmielin wants to merge 10 commits into
Conversation
|
@jimmielin NCAR/ccpp-framework#727 has been merged, can you ensure this fixes the issues you have been seeing? |
|
Thank you @mkavulich, yes, just tested with latest |
I actually think the correct units for the Boltzmann Constant really is just J K-1, even though comments in CAM-SIMA and CESM_share says otherwise. This is because the constant holds for any "particle" that can behave like a gas, which is technically not just molecules. It's the same reason a number density is technically just a per-volume unit (e.g. cm-3), and not molecules per volume (e.g. molecules cm-3). Co-authored-by: Jesse Nusbaumer <nusbaume@ucar.edu>
nusbaume
left a comment
There was a problem hiding this comment.
Thanks @jimmielin! I had one question, but nothing that should prevent this PR from getting merged.
| ! ozone and aerosols) | ||
| ! to create the "before" snapshot: | ||
| ! ncap2 -O -s 'pbuf_ozone=0.0*pbuf_ozone' h1i_v2.nc 0xozone.nc | ||
| ! ncap2 -O -s 'pbuf_sulf=0.0*pbuf_sulf;pbuf_bcar1=0.0*pbuf_sulf;pbuf_bcar2=0.0*pbuf_sulf;pbuf_ocar1=0.0*pbuf_sulf;pbuf_ocar2=0.0*pbuf_sulf;pbuf_sslt1=0.0*pbuf_sulf;pbuf_sslt2=0.0*pbuf_sulf;pbuf_sslt3=0.0*pbuf_sulf;pbuf_sslt4=0.0*pbuf_sulf;pbuf_dust1=0.0*pbuf_sulf;pbuf_dust2=0.0*pbuf_sulf;pbuf_dust3=0.0*pbuf_sulf;pbuf_dust4=0.0*pbuf_sulf;pbuf_VOLC_RAD_GEOM=0.0*pbuf_VOLC_RAD_GEOM;pbuf_VOLC_MMR=0.0*pbuf_VOLC_MMR' 0xozone.nc 0xozone_aero_volcaero.nc |
There was a problem hiding this comment.
Just double-checking if it is okay that many of these aerosol fields are zero times pbuf_sulf? It totally might be, I am just trying to understand the reasoning behind it. Thanks!
There was a problem hiding this comment.
Thanks for the question. Yes, it is intended! It is just to zero out these fields in the "before" snapshot, so that ncdata_check can verify that the zeros in the model state indeed were populated by the tracer_data schemes.
The reason I used <something>=0.0*pbuf_sulf is because nco with <something>=0.0 will set the 2-D array into a scalar, and thus losing the dimensions; so I just borrowed the pbuf_sulf*0.0 to get a 2-D array of zeros to put into that variable. Hope this explains it!
Companion PR: ESCOMP/atmospheric_physics#372
Tag name (required for release branches):
Originator(s):
Description (include the issue title, and the keyword ['closes', 'fixes', 'resolves'] followed by the issue number):
prescribed_volcanic_aerosolto be tested along with the rest of BAM prescribed code.Describe any changes made to build system: N/A
Describe any changes made to the namelist: N/A
List any changes to the defaults for the input datasets (e.g. boundary datasets):
List all files eliminated and why: N/A
List all files added and what they do: N/A
List all existing files that have been modified, and describe the changes:
(Helpful git command:
git diff --name-status development...<your_branch_name>)If there are new failures (compared to the
test/existing-test-failures.txtfile),have them OK'd by the gatekeeper, note them here, and add them to the file.
If there are baseline differences, include the test and the reason for the
diff. What is the nature of the change? Roundoff?
derecho/intel/aux_sima:
derecho/gnu/aux_sima:
derecho/nvhpc/aux_sima:
If this changes climate describe any run(s) done to evaluate the new
climate in enough detail that it(they) could be reproduced:
CAM-SIMA date used for the baseline comparison tests if different than latest: