Skip to content

i#8008 format: Remove non-UTF8 characters#8011

Merged
derekbruening merged 2 commits into
masterfrom
i8008-non-utf8
Jul 17, 2026
Merged

i#8008 format: Remove non-UTF8 characters#8011
derekbruening merged 2 commits into
masterfrom
i8008-non-utf8

Conversation

@derekbruening

@derekbruening derekbruening commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Removes non-UTF8 characters from tools/runjob.c.
These crash clang-format-diff and are blocking PR #8009.
Also fixes non-UTF8 characters found in two other files while at it.

Issue: #8008

Removes non-UTF8 characters from tools/runjob.c.
These crash clang-format-diff and are blocking PR #8009.

Issue: #8008

@bin-wang bin-wang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I scanned the repo and found 2 other files that contain non-UTF8 characters:

/* disabling b/c messes up the print: "success" comes out as "Ðuccess" */
buffer_test("crtheap");

and
AfxMessageBox (“Save failed!”);

They are not blocking #8009 but should we remove those as well?

@derekbruening

Copy link
Copy Markdown
Contributor Author

I scanned the repo and found 2 other files that contain non-UTF8 characters:

/* disabling b/c messes up the print: "success" comes out as "Ðuccess" */
buffer_test("crtheap");

and

AfxMessageBox (“Save failed!”);

They are not blocking #8009 but should we remove those as well?

May as well: I added them to this PR to fix all at once.

@derekbruening
derekbruening merged commit f051ce2 into master Jul 17, 2026
26 of 27 checks passed
@derekbruening
derekbruening deleted the i8008-non-utf8 branch July 17, 2026 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants