Fix: don't swap review labels on "Update branch"#1227
Merged
Conversation
|
❌ JSON Filename Check Failed
|
PR Description Check FailedThe PR description is missing required elements. Please update it according to the PR template. Details |
|
✅ JSON Schema Validation Passed |
Linter OK |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: don't swap review labels on "Update branch"
Problem
Clicking "Update branch" on a PR creates a merge commit from
masterinto the PR branch. This triggered thesynchronizeevent, causing the workflow to incorrectly swapreview issues→new review neededeven though the PR author had not pushed any new work.Example: commit
27072dddon PR #1218.Fix
In the trigger workflow, before treating a
synchronizeevent as new author work, check whether the head commit is a two-parent merge commit whose second parent matches the currentmastertip. If it is, skip the artifact upload entirely — no label changes are made.All other pushes (regular commits, force-pushes, author-initiated merges) continue to trigger the label swap as before.